* [PATCH] crypt: ablkcipher: remove redundant NULL check
@ 2011-01-25 16:27 ` Davidlohr Bueso
0 siblings, 0 replies; 6+ messages in thread
From: Davidlohr Bueso @ 2011-01-25 16:27 UTC (permalink / raw)
To: Herbert Xu, David Miller; +Cc: linux-crypto, LKML
From: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
crypto/ablkcipher.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/crypto/ablkcipher.c b/crypto/ablkcipher.c
index a854df2..fdc67d3 100644
--- a/crypto/ablkcipher.c
+++ b/crypto/ablkcipher.c
@@ -141,8 +141,7 @@ err:
if (walk->iv != req->info)
memcpy(req->info, walk->iv, tfm->crt_ablkcipher.ivsize);
- if (walk->iv_buffer)
- kfree(walk->iv_buffer);
+ kfree(walk->iv_buffer);
return err;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] crypt: ablkcipher: remove redundant NULL check
@ 2011-01-25 16:27 ` Davidlohr Bueso
0 siblings, 0 replies; 6+ messages in thread
From: Davidlohr Bueso @ 2011-01-25 16:27 UTC (permalink / raw)
To: Herbert Xu, David Miller; +Cc: linux-crypto, LKML
From: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
crypto/ablkcipher.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/crypto/ablkcipher.c b/crypto/ablkcipher.c
index a854df2..fdc67d3 100644
--- a/crypto/ablkcipher.c
+++ b/crypto/ablkcipher.c
@@ -141,8 +141,7 @@ err:
if (walk->iv != req->info)
memcpy(req->info, walk->iv, tfm->crt_ablkcipher.ivsize);
- if (walk->iv_buffer)
- kfree(walk->iv_buffer);
+ kfree(walk->iv_buffer);
return err;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] crypt: ablkcipher: remove redundant NULL check
2011-01-25 16:27 ` Davidlohr Bueso
@ 2011-01-25 20:39 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2011-01-25 20:39 UTC (permalink / raw)
To: dave; +Cc: herbert, linux-crypto, linux-kernel
From: Davidlohr Bueso <dave@gnu.org>
Date: Tue, 25 Jan 2011 13:27:45 -0300
> From: Davidlohr Bueso <dave@gnu.org>
>
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypt: ablkcipher: remove redundant NULL check
@ 2011-01-25 20:39 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2011-01-25 20:39 UTC (permalink / raw)
To: dave; +Cc: herbert, linux-crypto, linux-kernel
From: Davidlohr Bueso <dave@gnu.org>
Date: Tue, 25 Jan 2011 13:27:45 -0300
> From: Davidlohr Bueso <dave@gnu.org>
>
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypt: ablkcipher: remove redundant NULL check
2011-01-25 20:39 ` David Miller
@ 2011-01-29 4:10 ` Herbert Xu
-1 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2011-01-29 4:10 UTC (permalink / raw)
To: David Miller; +Cc: dave, linux-crypto, linux-kernel
On Tue, Jan 25, 2011 at 12:39:50PM -0800, David Miller wrote:
> From: Davidlohr Bueso <dave@gnu.org>
> Date: Tue, 25 Jan 2011 13:27:45 -0300
>
> > From: Davidlohr Bueso <dave@gnu.org>
> >
> > Signed-off-by: Davidlohr Bueso <dave@gnu.org>
>
> Acked-by: David S. Miller <davem@davemloft.net>
Patch applied. Thanks a lot!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypt: ablkcipher: remove redundant NULL check
@ 2011-01-29 4:10 ` Herbert Xu
0 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2011-01-29 4:10 UTC (permalink / raw)
To: David Miller; +Cc: dave, linux-crypto, linux-kernel
On Tue, Jan 25, 2011 at 12:39:50PM -0800, David Miller wrote:
> From: Davidlohr Bueso <dave@gnu.org>
> Date: Tue, 25 Jan 2011 13:27:45 -0300
>
> > From: Davidlohr Bueso <dave@gnu.org>
> >
> > Signed-off-by: Davidlohr Bueso <dave@gnu.org>
>
> Acked-by: David S. Miller <davem@davemloft.net>
Patch applied. Thanks a lot!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-01-29 4:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-25 16:27 [PATCH] crypt: ablkcipher: remove redundant NULL check Davidlohr Bueso
2011-01-25 16:27 ` Davidlohr Bueso
2011-01-25 20:39 ` David Miller
2011-01-25 20:39 ` David Miller
2011-01-29 4:10 ` Herbert Xu
2011-01-29 4:10 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.