From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752250Ab1AYB7h (ORCPT ); Mon, 24 Jan 2011 20:59:37 -0500 Received: from kroah.org ([198.145.64.141]:56994 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751522Ab1AYB7g (ORCPT ); Mon, 24 Jan 2011 20:59:36 -0500 Date: Tue, 25 Jan 2011 10:00:31 +0800 From: Greg KH To: Mike Waychison Cc: torvalds@linux-foundation.org, San Mehat , Aaron Durbin , Duncan Laurie , linux-kernel@vger.kernel.org, Tim Hockin Subject: Re: [PATCH v1 6/6] driver: Google Memory Console Message-ID: <20110125020031.GA3389@kroah.com> References: <20110125002433.12637.51091.stgit@mike.mtv.corp.google.com> <20110125002505.12637.84140.stgit@mike.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110125002505.12637.84140.stgit@mike.mtv.corp.google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 24, 2011 at 04:25:05PM -0800, Mike Waychison wrote: > This patch introduces the 'memconsole' driver. > > Our firmware gives us access to an in-memory log of the firmware's > output. This gives us visibility in a data-center of headless machines > as to what the firmware is doing. > > The memory console is found by the driver by finding a header block in > the EBDA. The buffer is then copied out, and is currently prepended > to the kernel's dmesg ring-buffer. Why does this have to be the first thing in the dmesg buffer? What's wrong with it showing up whenever this driver is loaded like all other drivers? thanks, greg k-h