From: Dan Williams <dan.j.williams@intel.com>
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org,
Krzysztof Wasilewski <krzysztof.wasilewski@intel.com>,
Przemyslaw Czarnowski
<przemyslaw.hawrylewicz.czarnowski@intel.com>
Subject: [PATCH] fix extended partition detection
Date: Mon, 24 Jan 2011 18:54:06 -0800 [thread overview]
Message-ID: <20110125025303.18675.61317.stgit@localhost6.localdomain6> (raw)
# mdadm --detail --export /dev/md127p1
Before:
MD_LEVEL=raid5
MD_DEVICES=4
MD_METADATA=0.90
After:
MD_LEVEL=raid5
MD_DEVICES=4
MD_CONTAINER=/dev/md0
MD_MEMBER=0
MD_UUID=55746a20:925d24a7:4f9bd7e2:9c9a411f
We parse the symlink target with a format:
../../block/mdXXX/mdXXXpYY
...and need the second '/' from the end of the string to read detect a
'md' device.
Reported-by: Krzysztof Wasilewski <krzysztof.wasilewski@intel.com>
Cc: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
[ sorry for any duplicates or triplicates, I failed to notice that my
MTA was misconfigured after an upgrade to F13, and all my mail from
stgit was getting rejected externally. ]
If there are any 3.1.x stable releases planned I would consider this a
candidate as it allows custom name partitions to be created by udev
(like /dev/md/vol1p1). I believe this was masked by the usage of mdp
devices.
On 3.2 it exposes a segfault as we try to get the container_content()
of 'mbr' metadata.
util.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/util.c b/util.c
index c9bdd6e..75a5e6d 100644
--- a/util.c
+++ b/util.c
@@ -1664,7 +1664,7 @@ int stat2devnum(struct stat *st)
link[n] = 0;
cp = strrchr(link, '/');
if (cp) *cp = 0;
- cp = strchr(link, '/');
+ cp = strrchr(link, '/');
if (cp && strncmp(cp, "/md", 3) == 0)
return devname2devnum(cp+1);
}
next reply other threads:[~2011-01-25 2:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 2:54 Dan Williams [this message]
2011-01-27 2:58 ` [PATCH] fix extended partition detection Neil Brown
[not found] <20110114013731.14866.3356.stgit@localhost6.localdomain6>
2011-01-20 11:28 ` Hawrylewicz Czarnowski, Przemyslaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110125025303.18675.61317.stgit@localhost6.localdomain6 \
--to=dan.j.williams@intel.com \
--cc=krzysztof.wasilewski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=przemyslaw.hawrylewicz.czarnowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.