From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p0P9owX0235919 for ; Tue, 25 Jan 2011 03:50:58 -0600 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 245231A1EA06 for ; Tue, 25 Jan 2011 01:53:22 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id 0s1W19AHaKKYzH3e for ; Tue, 25 Jan 2011 01:53:22 -0800 (PST) Date: Tue, 25 Jan 2011 04:53:21 -0500 From: Christoph Hellwig Subject: Re: [PATCH 7/8] xfs: handle CIl transaction commit failures correctly Message-ID: <20110125095321.GC23990@infradead.org> References: <1295945444-29488-1-git-send-email-david@fromorbit.com> <1295945444-29488-8-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1295945444-29488-8-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Tue, Jan 25, 2011 at 07:50:43PM +1100, Dave Chinner wrote: > From: Dave Chinner > > Failure to commit a transaction into the CIL is not handled > correctly. This currently can only happen when racing with a > shutdown and requires an explicit shutdown check, so it rare and can > be avoided. Remove the shutdown check and make the CIL commit a void > function to indicate it will always succeed, thereby removing the > incorrectly handled failure case. Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs