From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754006Ab1AYSDi (ORCPT ); Tue, 25 Jan 2011 13:03:38 -0500 Received: from casper.infradead.org ([85.118.1.10]:59943 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753551Ab1AYR7b (ORCPT ); Tue, 25 Jan 2011 12:59:31 -0500 Message-Id: <20110125174907.220115681@chello.nl> User-Agent: quilt/0.48-1 Date: Tue, 25 Jan 2011 18:31:12 +0100 From: Peter Zijlstra To: Andrea Arcangeli , Avi Kivity , Thomas Gleixner , Rik van Riel , Ingo Molnar , akpm@linux-foundation.org, Linus Torvalds Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Benjamin Herrenschmidt , David Miller , Hugh Dickins , Mel Gorman , Nick Piggin , Peter Zijlstra , Paul McKenney , Yanmin Zhang , Chris Metcalf Subject: [PATCH 01/25] tile: Fix __pte_free_tlb References: <20110125173111.720927511@chello.nl> Content-Disposition: inline; filename=tile-fix-pte_free_tlb.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tile's __pte_free_tlb() implementation makes assumptions about the generic mmu_gather implementation, cure this ;-) [ Chris, from a quick look L2_USER_PGTABLE_PAGES is something like: 1 << (24 - 16 + 3), which looks awefully large for an on-stack array. ] Cc: Chris Metcalf Signed-off-by: Peter Zijlstra --- arch/tile/mm/pgtable.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) Index: linux-2.6/arch/tile/mm/pgtable.c =================================================================== --- linux-2.6.orig/arch/tile/mm/pgtable.c +++ linux-2.6/arch/tile/mm/pgtable.c @@ -252,19 +252,8 @@ void __pte_free_tlb(struct mmu_gather *t int i; pgtable_page_dtor(pte); - tlb->need_flush = 1; - if (tlb_fast_mode(tlb)) { - struct page *pte_pages[L2_USER_PGTABLE_PAGES]; - for (i = 0; i < L2_USER_PGTABLE_PAGES; ++i) - pte_pages[i] = pte + i; - free_pages_and_swap_cache(pte_pages, L2_USER_PGTABLE_PAGES); - return; - } - for (i = 0; i < L2_USER_PGTABLE_PAGES; ++i) { - tlb->pages[tlb->nr++] = pte + i; - if (tlb->nr >= FREE_PTE_NR) - tlb_flush_mmu(tlb, 0, 0); - } + for (i = 0; i < L2_USER_PGTABLE_PAGES; ++i) + tlb_remove_page(tlb, pte + i); } #ifndef __tilegx__ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: [PATCH 01/25] tile: Fix __pte_free_tlb Date: Tue, 25 Jan 2011 18:31:12 +0100 Message-ID: <20110125174907.220115681@chello.nl> References: <20110125173111.720927511@chello.nl> Return-path: Content-Disposition: inline; filename=tile-fix-pte_free_tlb.patch Sender: linux-kernel-owner@vger.kernel.org To: Andrea Arcangeli , Avi Kivity , Thomas Gleixner , Rik van Riel , Ingo Molnar , akpm@linux-fou Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Benjamin Herrenschmidt , David Miller , Hugh Dickins , Mel Gorman , Nick Piggin , Peter Zijlstra , Paul McKenney , Yanmin Zhang , Chris Metcalf List-Id: linux-arch.vger.kernel.org Tile's __pte_free_tlb() implementation makes assumptions about the generic mmu_gather implementation, cure this ;-) [ Chris, from a quick look L2_USER_PGTABLE_PAGES is something like: 1 << (24 - 16 + 3), which looks awefully large for an on-stack array. ] Cc: Chris Metcalf Signed-off-by: Peter Zijlstra --- arch/tile/mm/pgtable.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) Index: linux-2.6/arch/tile/mm/pgtable.c =================================================================== --- linux-2.6.orig/arch/tile/mm/pgtable.c +++ linux-2.6/arch/tile/mm/pgtable.c @@ -252,19 +252,8 @@ void __pte_free_tlb(struct mmu_gather *t int i; pgtable_page_dtor(pte); - tlb->need_flush = 1; - if (tlb_fast_mode(tlb)) { - struct page *pte_pages[L2_USER_PGTABLE_PAGES]; - for (i = 0; i < L2_USER_PGTABLE_PAGES; ++i) - pte_pages[i] = pte + i; - free_pages_and_swap_cache(pte_pages, L2_USER_PGTABLE_PAGES); - return; - } - for (i = 0; i < L2_USER_PGTABLE_PAGES; ++i) { - tlb->pages[tlb->nr++] = pte + i; - if (tlb->nr >= FREE_PTE_NR) - tlb_flush_mmu(tlb, 0, 0); - } + for (i = 0; i < L2_USER_PGTABLE_PAGES; ++i) + tlb_remove_page(tlb, pte + i); } #ifndef __tilegx__ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id D80BB6B0092 for ; Tue, 25 Jan 2011 13:38:17 -0500 (EST) Message-Id: <20110125174907.220115681@chello.nl> Date: Tue, 25 Jan 2011 18:31:12 +0100 From: Peter Zijlstra Subject: [PATCH 01/25] tile: Fix __pte_free_tlb References: <20110125173111.720927511@chello.nl> Content-Disposition: inline; filename=tile-fix-pte_free_tlb.patch Sender: owner-linux-mm@kvack.org To: Andrea Arcangeli , Avi Kivity , Thomas Gleixner , Rik van Riel , Ingo Molnar , akpm@linux-foundation.org, Linus Torvalds Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Benjamin Herrenschmidt , David Miller , Hugh Dickins , Mel Gorman , Nick Piggin , Peter Zijlstra , Paul McKenney , Yanmin Zhang , Chris Metcalf List-ID: Tile's __pte_free_tlb() implementation makes assumptions about the generic mmu_gather implementation, cure this ;-) [ Chris, from a quick look L2_USER_PGTABLE_PAGES is something like: 1 << (24 - 16 + 3), which looks awefully large for an on-stack array. ] Cc: Chris Metcalf Signed-off-by: Peter Zijlstra --- arch/tile/mm/pgtable.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) Index: linux-2.6/arch/tile/mm/pgtable.c =================================================================== --- linux-2.6.orig/arch/tile/mm/pgtable.c +++ linux-2.6/arch/tile/mm/pgtable.c @@ -252,19 +252,8 @@ void __pte_free_tlb(struct mmu_gather *t int i; pgtable_page_dtor(pte); - tlb->need_flush = 1; - if (tlb_fast_mode(tlb)) { - struct page *pte_pages[L2_USER_PGTABLE_PAGES]; - for (i = 0; i < L2_USER_PGTABLE_PAGES; ++i) - pte_pages[i] = pte + i; - free_pages_and_swap_cache(pte_pages, L2_USER_PGTABLE_PAGES); - return; - } - for (i = 0; i < L2_USER_PGTABLE_PAGES; ++i) { - tlb->pages[tlb->nr++] = pte + i; - if (tlb->nr >= FREE_PTE_NR) - tlb_flush_mmu(tlb, 0, 0); - } + for (i = 0; i < L2_USER_PGTABLE_PAGES; ++i) + tlb_remove_page(tlb, pte + i); } #ifndef __tilegx__ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org