From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34820 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PhnH2-0004pY-EF
	for qemu-devel@nongnu.org; Tue, 25 Jan 2011 13:05:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1PhnH0-0001no-Hm
	for qemu-devel@nongnu.org; Tue, 25 Jan 2011 13:05:48 -0500
Received: from verein.lst.de ([213.95.11.210]:46953)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1PhnH0-0001jM-1u
	for qemu-devel@nongnu.org; Tue, 25 Jan 2011 13:05:46 -0500
Date: Tue, 25 Jan 2011 19:05:37 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] block: add block_resize monitor command
Message-ID: <20110125180537.GA4087@lst.de>
References: <20110124123223.GA16558@lst.de> <20110124123233.GA16613@lst.de>
	<20110124174416.GA6178@amt.cnet> <4D3EBB80.1000107@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D3EBB80.1000107@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On Tue, Jan 25, 2011 at 01:01:04PM +0100, Kevin Wolf wrote:
> > Can't resize if block migration is in progress. Don't see a problem 
> > with simply disallowing resize in that case.
> 
> Then we should add a check to bdrv_truncate.

What check exactly would that be anyway?