[Buildroot] [git commit master 1/1] Use sys-root rather than sysroot for the sysroot/staging_dir

[Buildroot] [git commit master 1/1] Use sys-root rather than sysroot for the sysroot/staging_dir

[Peter Korsgaard]

commit: http://git.buildroot.net/buildroot/commit/?id=8f61b236c9e70853e21730ad7889be9c3d23f94d
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The name of the sysroot directory is arbitrary, but as ct-ng uses sys-root,
let's use that as well for consistency.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 package/Makefile.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/Makefile.in b/package/Makefile.in
index a1e290f..fae0e0e 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -35,7 +35,7 @@ endif
 
 REAL_GNU_TARGET_NAME=$(ARCH)-unknown-linux-$(LIBC)$(ABI)
 
-STAGING_DIR=$(HOST_DIR)/usr/$(REAL_GNU_TARGET_NAME)/sysroot
+STAGING_DIR=$(HOST_DIR)/usr/$(REAL_GNU_TARGET_NAME)/sys-root
 
 ifeq ($(BR2_OPTIMIZE_0),y)
 TARGET_OPTIMIZATION+=-O0
-- 
1.7.3.4

[Buildroot] [git commit master 1/1] Use sys-root rather than sysroot for the sysroot/staging_dir

[Yann E. MORIN]

Peter, All,

On Tuesday 25 January 2011 16:08:50 Peter Korsgaard wrote:
> The name of the sysroot directory is arbitrary, but as ct-ng uses sys-root,
> let's use that as well for consistency.

As Thomas said on IRC, I would suggest to revert this. Is there anything
in BR that depends on the sysroot being named 'sysroot' or 'sys-root' at all,
or was that just an eye-candy change? (genuine question)

I will push the change in crosstool-NG that makes this configurable, and
the default is now 'sysroot', instead of the old hard-coded 'sys-root'.

Then, it will be a matter of taste what to set it to, with BR forcing it
to whatever suits (I believe just 'sysroot').

Also, note that not all toolchains set this to any of 'sysroot' or 'sys-root'.
For example, the CodeSourcery toolchains set this to 'libc' for the main
sysroot, and to libc/${variant} for each supported variant's sysroot.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [git commit master 1/1] Use sys-root rather than sysroot for the sysroot/staging_dir

[Thomas Petazzoni]

On Tue, 25 Jan 2011 22:39:36 +0100
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> wrote:

> As Thomas said on IRC, I would suggest to revert this. Is there anything
> in BR that depends on the sysroot being named 'sysroot' or 'sys-root' at all,
> or was that just an eye-candy change? (genuine question)

Just for the record, my preference for "sysroot" instead of "sys-root"
is because all sysroot-related options in gcc use the "sysroot"
spelling and not "sys-root" :

 -print-sysroot
 -print-sysroot-headers-suffix
 --sysroot

And all gcc documentation refers to it as the "sysroot" :

`-print-sysroot'
     Print the target sysroot directory that will be used during
     compilation.  This is the target sysroot specified either at
     configure time or using the `--sysroot' option, possibly with an
     extra suffix that depends on compilation options.  If no target
     sysroot is specified, the option prints nothing.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [git commit master 1/1] Use sys-root rather than sysroot for the sysroot/staging_dir

[Yann E. MORIN]

Thomas, All,

On Tuesday 25 January 2011 22:50:53 Thomas Petazzoni wrote:
> Just for the record, my preference for "sysroot" instead of "sys-root"
> is because all sysroot-related options in gcc use the "sysroot"
> spelling and not "sys-root" :

Yes, agreed. That's the reason I also changed the default in crosstool-NG
to 'sysroot', to match the literature.

The 'sys-root' name comes from the original crosstool:
  http://code.google.com/p/crosstool/source/browse/trunk/src/crosstool.sh#320

I saw no reason to change it at the time, although I hae no strong opinion
about it (so I renamed).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [git commit master 1/1] Use sys-root rather than sysroot for the sysroot/staging_dir

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@anciens.enib.fr> writes:

 Yann> Peter, All,
 Yann> On Tuesday 25 January 2011 16:08:50 Peter Korsgaard wrote:
 >> The name of the sysroot directory is arbitrary, but as ct-ng uses sys-root,
 >> let's use that as well for consistency.

 Yann> As Thomas said on IRC, I would suggest to revert this. Is there
 Yann> anything in BR that depends on the sysroot being named 'sysroot'
 Yann> or 'sys-root' at all, or was that just an eye-candy change?
 Yann> (genuine question)

No, as mentioned - The name is arbitrary, but as the ct-ng version we're
currently using hardcodes it as sys-root, then we either need to use
sys-root or add symlinks if we want ct-ng to install directly into
HOST_DIR/usr to get BR's and ct-ng's idea of $tuple/sys-root to match.

 Yann> I will push the change in crosstool-NG that makes this
 Yann> configurable, and the default is now 'sysroot', instead of the
 Yann> old hard-coded 'sys-root'.

Ok, good.

 Yann> Then, it will be a matter of taste what to set it to, with BR forcing it
 Yann> to whatever suits (I believe just 'sysroot').

Yeah. Until very recently noone really cared as STAGING_DIR used to be
directly in output/.

 Yann> Also, note that not all toolchains set this to any of 'sysroot'
 Yann> or 'sys-root'.  For example, the CodeSourcery toolchains set this
 Yann> to 'libc' for the main sysroot, and to libc/${variant} for each
 Yann> supported variant's sysroot.

Yes, but that's OK. This change was just to get the ct-ng toolchain to
behave more similar to the internal one.

-- 
Bye, Peter Korsgaard