All of lore.kernel.org
 help / color / mirror / Atom feed
* [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled
@ 2011-01-09 21:55 bugzilla-daemon
  2011-01-09 23:07 ` [Bug 32945] " bugzilla-daemon
                   ` (28 more replies)
  0 siblings, 29 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-09 21:55 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

           Summary: Lower part of the screen corrupt with HyperZ enabled
           Product: Mesa
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/r300
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: sa@whiz.se


Created an attachment (id=41815)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=41815)
Screenshot of gears

When HyperZ is used on my RV570 the lower part of the screen isn't rendered
correctly.  I'm attaching a screenshot of glxgears, but it's also visible in
most real-world games and apps.

I'm not sure if this is the same as bug 29851 since the hardware differs.

(HyperZ gives a pretty nice performance boost otherwise, about a 30% fps
increase with Doom 3 in 1680x1050!) 

System environment:
-- system architecture: 32-bit
-- Linux distribution: Debian unstable
-- GPU: RV570
-- Model: Asus EAX1950Pro 256MB
-- Display connector: DVI
-- xf86-video-ati: 6.13.2
-- xserver: 1.9.2
-- mesa: ac6306e9ca904ae9674bf2a15222efe4cb861bf5
-- drm: 2.4.23
-- kernel: 2.6.37

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
@ 2011-01-09 23:07 ` bugzilla-daemon
  2011-01-10 16:00 ` bugzilla-daemon
                   ` (27 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-09 23:07 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #1 from Marek Olšák <maraeo@gmail.com> 2011-01-09 15:07:37 PST ---
Doesn't the performance boost come from the fact that a large part of the
screen is not rendered?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
  2011-01-09 23:07 ` [Bug 32945] " bugzilla-daemon
@ 2011-01-10 16:00 ` bugzilla-daemon
  2011-01-25  5:00 ` bugzilla-daemon
                   ` (26 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-10 16:00 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #2 from Sven Arvidsson <sa@whiz.se> 2011-01-10 08:00:41 PST ---
Doh! Yeah, I suppose that's a lot more plausible.(In reply to comment #1)
> Doesn't the performance boost come from the fact that a large part of the
> screen is not rendered?

Doh! Yeah, I suppose that's a lot more plausible.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
  2011-01-09 23:07 ` [Bug 32945] " bugzilla-daemon
  2011-01-10 16:00 ` bugzilla-daemon
@ 2011-01-25  5:00 ` bugzilla-daemon
  2011-01-25 14:32 ` bugzilla-daemon
                   ` (25 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-25  5:00 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #3 from Marek Olšák <maraeo@gmail.com> 2011-01-24 21:00:14 PST ---
Does this patch fix anything?

https://bugs.freedesktop.org/attachment.cgi?id=42432

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (2 preceding siblings ...)
  2011-01-25  5:00 ` bugzilla-daemon
@ 2011-01-25 14:32 ` bugzilla-daemon
  2011-01-25 14:34 ` bugzilla-daemon
                   ` (24 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-25 14:32 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #4 from Sven Arvidsson <sa@whiz.se> 2011-01-25 06:32:09 PST ---
Created an attachment (id=42458)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42458)
glxgears screenshot with patch

The patch is a big improvment, but it doesn't completely solve it. 

I'm attaching a screenshot of glxgears. In Doom3 the bug seems to mostly
involve the gun, any time it's moved there's a sort of black after image still
visible on the screen.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (3 preceding siblings ...)
  2011-01-25 14:32 ` bugzilla-daemon
@ 2011-01-25 14:34 ` bugzilla-daemon
  2011-01-25 15:54 ` bugzilla-daemon
                   ` (23 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-25 14:34 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #5 from Sven Arvidsson <sa@whiz.se> 2011-01-25 06:34:55 PST ---
Created an attachment (id=42459)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42459)
screenshot from doom3

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (4 preceding siblings ...)
  2011-01-25 14:34 ` bugzilla-daemon
@ 2011-01-25 15:54 ` bugzilla-daemon
  2011-01-25 16:06 ` bugzilla-daemon
                   ` (22 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-25 15:54 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #6 from Marek Olšák <maraeo@gmail.com> 2011-01-25 07:54:26 PST ---
I've made a new patch. Could you give it a try?

https://bugs.freedesktop.org/attachment.cgi?id=42464

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (5 preceding siblings ...)
  2011-01-25 15:54 ` bugzilla-daemon
@ 2011-01-25 16:06 ` bugzilla-daemon
  2011-01-25 16:33 ` bugzilla-daemon
                   ` (21 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-25 16:06 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

Sven Arvidsson <sa@whiz.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42459|0                           |1
        is obsolete|                            |

--- Comment #7 from Sven Arvidsson <sa@whiz.se> 2011-01-25 08:06:53 PST ---
Created an attachment (id=42469)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42469)
doom3 with second version of patch

(In reply to comment #6)
> I've made a new patch. Could you give it a try?
> 
> https://bugs.freedesktop.org/attachment.cgi?id=42464

This seems slightly worse. Not much difference in glxgears, but in Doom3 the
corruption is a lot more persistent.

Not sure if it's relevant, but in glxgears, the amount of corruption depends on
what angle you're viewing the gears from.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (6 preceding siblings ...)
  2011-01-25 16:06 ` bugzilla-daemon
@ 2011-01-25 16:33 ` bugzilla-daemon
  2011-01-25 22:29 ` bugzilla-daemon
                   ` (20 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-25 16:33 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #8 from Marek Olšák <maraeo@gmail.com> 2011-01-25 08:33:52 PST ---
It appears that one third of the zbuffer is not cleared on your machine. In
src/gallium/drivers/r300/r300_emit.c, can you add this line:

numdw = ALIGN_DIVUP(numdw * 3, 2);

at line 1171 and do some testing?

Could you also please attach your dmesg?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (7 preceding siblings ...)
  2011-01-25 16:33 ` bugzilla-daemon
@ 2011-01-25 22:29 ` bugzilla-daemon
  2011-01-25 22:55 ` bugzilla-daemon
                   ` (19 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-25 22:29 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #9 from Sven Arvidsson <sa@whiz.se> 2011-01-25 14:29:28 PST ---
Created an attachment (id=42495)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42495)
dmesg output

(In reply to comment #8)
> It appears that one third of the zbuffer is not cleared on your machine. In
> src/gallium/drivers/r300/r300_emit.c, can you add this line:
> 
> numdw = ALIGN_DIVUP(numdw * 3, 2);
> 
> at line 1171 and do some testing?
> 
> Could you also please attach your dmesg?

Adding the line didn't make any difference. 

In fact, I did some poking around (without any real understanding) and the
value of numdw doesn't seem to make any difference. Replacing OUT_CS(numdw);
with OUT_CS(0); gives the same result here. But maybe that's expected?

dmesg is attached.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (8 preceding siblings ...)
  2011-01-25 22:29 ` bugzilla-daemon
@ 2011-01-25 22:55 ` bugzilla-daemon
  2011-01-25 23:37 ` bugzilla-daemon
                   ` (18 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-25 22:55 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #10 from Marek Olšák <maraeo@gmail.com> 2011-01-25 14:55:02 PST ---
It doesn't add up. Changing numdw must make a visible difference, it determines
how many pixels are cleared (multiplied by something).

I don't think 0 is even allowed. Try 1 and see how large part of the screen is
rendered correctly. It should be 64x64 or something like that, I don't know for
sure. Knowing that size would come in handy. The rest of the screen should be
corrupted.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (9 preceding siblings ...)
  2011-01-25 22:55 ` bugzilla-daemon
@ 2011-01-25 23:37 ` bugzilla-daemon
  2011-01-26  0:38 ` bugzilla-daemon
                   ` (17 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-25 23:37 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #11 from Sven Arvidsson <sa@whiz.se> 2011-01-25 15:37:15 PST ---
(In reply to comment #10)
> It doesn't add up. Changing numdw must make a visible difference, it determines
> how many pixels are cleared (multiplied by something).
> 
> I don't think 0 is even allowed. Try 1 and see how large part of the screen is
> rendered correctly. It should be 64x64 or something like that, I don't know for
> sure. Knowing that size would come in handy. The rest of the screen should be
> corrupted.

With 1 the whole screen is corrupt and mostly black - but you can still see
part of the gears flickering though it's hard to catch in a screenshot.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (10 preceding siblings ...)
  2011-01-25 23:37 ` bugzilla-daemon
@ 2011-01-26  0:38 ` bugzilla-daemon
  2011-01-26 15:59 ` bugzilla-daemon
                   ` (16 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-26  0:38 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #12 from Marek Olšák <maraeo@gmail.com> 2011-01-25 16:38:57 PST ---
Created an attachment (id=42497)
 View: https://bugs.freedesktop.org/attachment.cgi?id=42497
 Review: https://bugs.freedesktop.org/review?bug=32945&attachment=42497

hyperz fix v3

Thanks for your time. I've attached a new patch. It fixes more bugs and
although it doesn't fix yours, it's needed for additional testing.

Please do the following.

1) Use numdw = 1.

2) Download Mesa demos if you don't already have them.
(git://anongit.freedesktop.org/mesa/demos, compile with "cmake .; make")

3) Go to src/demos.

4) Execute ./shadowtex with hyperz enabled. Press 'i'.

5) Hold 'p'. You should see flickering all over the screen, but there should be
a little tile in the bottom left-hand corner. How large is the tile?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (11 preceding siblings ...)
  2011-01-26  0:38 ` bugzilla-daemon
@ 2011-01-26 15:59 ` bugzilla-daemon
  2011-01-28  0:10 ` bugzilla-daemon
                   ` (15 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-26 15:59 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #13 from Sven Arvidsson <sa@whiz.se> 2011-01-26 07:59:30 PST ---
Created an attachment (id=42527)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42527)
shadowtex screenshot

Okay, so if I have done this correctly, the small white area in the left corner
is 48x16, if you mean the larger black and white rendering it seems to be
256x257.

I'm attaching a screenshot of shadowtex.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (12 preceding siblings ...)
  2011-01-26 15:59 ` bugzilla-daemon
@ 2011-01-28  0:10 ` bugzilla-daemon
  2011-01-28 11:08 ` bugzilla-daemon
                   ` (14 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-28  0:10 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #14 from Marek Olšák <maraeo@gmail.com> 2011-01-27 16:10:23 PST ---
I have fixed the 8x8 compression mode in master. It should fix the bottom of
the screen being uninitialized. Please test.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (13 preceding siblings ...)
  2011-01-28  0:10 ` bugzilla-daemon
@ 2011-01-28 11:08 ` bugzilla-daemon
  2011-01-28 12:38 ` bugzilla-daemon
                   ` (13 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-28 11:08 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #15 from Marek Olšák <maraeo@gmail.com> 2011-01-28 03:08:44 PST ---
If the latest commits don't help, please add the following line at the end of
r300_chipset.c and test again:

caps->hiz_ram = 0;

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] Lower part of the screen corrupt with HyperZ enabled
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (14 preceding siblings ...)
  2011-01-28 11:08 ` bugzilla-daemon
@ 2011-01-28 12:38 ` bugzilla-daemon
  2011-02-11  2:10 ` [Bug 32945] [r300g] HyperZ: Wrong size in the HiZ clear packet causes the zbuffer not to be fully cleared bugzilla-daemon
                   ` (12 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-01-28 12:38 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #16 from Sven Arvidsson <sa@whiz.se> 2011-01-28 04:38:04 PST ---
No change with the latest commits, but caps->hiz_ram = 0; makes the problem go
away.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] [r300g] HyperZ: Wrong size in the HiZ clear packet causes the zbuffer not to be fully cleared
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (15 preceding siblings ...)
  2011-01-28 12:38 ` bugzilla-daemon
@ 2011-02-11  2:10 ` bugzilla-daemon
  2011-03-01  0:34 ` bugzilla-daemon
                   ` (11 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-02-11  2:10 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Lower part of the screen    |[r300g] HyperZ: Wrong size
                   |corrupt with HyperZ enabled |in the HiZ clear packet
                   |                            |causes the zbuffer not to
                   |                            |be fully cleared

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] [r300g] HyperZ: Wrong size in the HiZ clear packet causes the zbuffer not to be fully cleared
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (16 preceding siblings ...)
  2011-02-11  2:10 ` [Bug 32945] [r300g] HyperZ: Wrong size in the HiZ clear packet causes the zbuffer not to be fully cleared bugzilla-daemon
@ 2011-03-01  0:34 ` bugzilla-daemon
  2011-03-01 12:05 ` bugzilla-daemon
                   ` (10 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-03-01  0:34 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #17 from Marek Olšák <maraeo@gmail.com> 2011-02-28 16:34:37 PST ---
Please check out the latest Mesa master branch. There are some new fixes, which
should fix even this bug.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] [r300g] HyperZ: Wrong size in the HiZ clear packet causes the zbuffer not to be fully cleared
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (17 preceding siblings ...)
  2011-03-01  0:34 ` bugzilla-daemon
@ 2011-03-01 12:05 ` bugzilla-daemon
  2011-03-01 12:06 ` bugzilla-daemon
                   ` (9 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-03-01 12:05 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

Sven Arvidsson <sa@whiz.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41815|0                           |1
        is obsolete|                            |
  Attachment #42458|0                           |1
        is obsolete|                            |
  Attachment #42469|0                           |1
        is obsolete|                            |

--- Comment #18 from Sven Arvidsson <sa@whiz.se> 2011-03-01 04:05:00 PST ---
Created an attachment (id=43961)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=43961)
Screenshot of ETQW

(In reply to comment #17)
> Please check out the latest Mesa master branch. There are some new fixes, which
> should fix even this bug.

Things are considerably better now. The corruption in gears and doom3 seems to
be completely gone. (And the speedup in doom is around 40%!)

There's still something funky in ETQW, on the left and right sides. A
screenshot is attached.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] [r300g] HyperZ: Wrong size in the HiZ clear packet causes the zbuffer not to be fully cleared
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (18 preceding siblings ...)
  2011-03-01 12:05 ` bugzilla-daemon
@ 2011-03-01 12:06 ` bugzilla-daemon
  2011-03-03 20:52 ` bugzilla-daemon
                   ` (8 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-03-01 12:06 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

Sven Arvidsson <sa@whiz.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42527|0                           |1
        is obsolete|                            |

--- Comment #19 from Sven Arvidsson <sa@whiz.se> 2011-03-01 04:06:20 PST ---
Created an attachment (id=43962)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=43962)
shadowtex

Attaching new shadowtex screenshot in case that's useful.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] [r300g] HyperZ: Wrong size in the HiZ clear packet causes the zbuffer not to be fully cleared
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (19 preceding siblings ...)
  2011-03-01 12:06 ` bugzilla-daemon
@ 2011-03-03 20:52 ` bugzilla-daemon
  2011-03-06 22:07 ` bugzilla-daemon
                   ` (7 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-03-03 20:52 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #20 from Marek Olšák <maraeo@gmail.com> 2011-03-03 12:52:56 PST ---
I can't fix this by myself, because I don't have your GPU. If you want to play
with it, here's how:

In mesa/src/gallium/drivers/r300, there is file r300_texture_desc.c. On lines
356 and 357, there are two arrays containing info how HiZ buffers should be
aligned:

static unsigned hiz_align_x[4] = {8, 32, 48, 32};
static unsigned hiz_align_y[4] = {8, 8, 8, 32};

The 3rd element in those arrays contains a number for your GPU (because your
GPU has 3 pipes). Currently the alignment is 48x8. Feel free to try a different
size, like 32x32, 64x64, 48x32, whatever comes to your mind.

If nothing helps, it means the alignment is right and the problem is somewhere
else.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] [r300g] HyperZ: Wrong size in the HiZ clear packet causes the zbuffer not to be fully cleared
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (20 preceding siblings ...)
  2011-03-03 20:52 ` bugzilla-daemon
@ 2011-03-06 22:07 ` bugzilla-daemon
  2011-03-06 22:12 ` bugzilla-daemon
                   ` (6 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-03-06 22:07 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

Nicolas Peninguy <npeninguy@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |npeninguy@gmail.com

--- Comment #21 from Nicolas Peninguy <npeninguy@gmail.com> 2011-03-06 14:07:08 PST ---
I can see the same problems in shadowtex with a "ATI Technologies Inc R580
[Radeon X1900]" card. (MESA master)

Moreover while the comment at the start of r300_setup_hyperz_properties() says
a R580 should have 4 pipes, when I print the "pipes" variable, its value is 3.

Anyway playing with hiz_align_(x|y) values doesn't change anything for me.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] [r300g] HyperZ: Wrong size in the HiZ clear packet causes the zbuffer not to be fully cleared
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (21 preceding siblings ...)
  2011-03-06 22:07 ` bugzilla-daemon
@ 2011-03-06 22:12 ` bugzilla-daemon
  2011-03-07 20:01 ` [Bug 32945] [RADEON:KMS:R300G] " bugzilla-daemon
                   ` (5 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-03-06 22:12 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #22 from Sven Arvidsson <sa@whiz.se> 2011-03-06 14:12:34 PST ---
(In reply to comment #21)
> Anyway playing with hiz_align_(x|y) values doesn't change anything for me.

I've been doing the same, with no change in behaviour. So I guess the problem
is somewhere else? :/

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] [RADEON:KMS:R300G] HyperZ: Wrong size in the HiZ clear packet causes the zbuffer not to be fully cleared
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (22 preceding siblings ...)
  2011-03-06 22:12 ` bugzilla-daemon
@ 2011-03-07 20:01 ` bugzilla-daemon
  2011-03-07 20:41 ` [Bug 32945] [RADEON:KMS:R300G] HiZ: Weird behavior with 3 pipes bugzilla-daemon
                   ` (4 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-03-07 20:01 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

Jerome Glisse <glisse@freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[r300g] HyperZ: Wrong size  |[RADEON:KMS:R300G] HyperZ:
                   |in the HiZ clear packet     |Wrong size in the HiZ clear
                   |causes the zbuffer not to   |packet causes the zbuffer
                   |be fully cleared            |not to be fully cleared

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] [RADEON:KMS:R300G] HiZ: Weird behavior with 3 pipes
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (23 preceding siblings ...)
  2011-03-07 20:01 ` [Bug 32945] [RADEON:KMS:R300G] " bugzilla-daemon
@ 2011-03-07 20:41 ` bugzilla-daemon
  2011-03-10 21:13 ` bugzilla-daemon
                   ` (3 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-03-07 20:41 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[RADEON:KMS:R300G] HyperZ:  |[RADEON:KMS:R300G] HiZ:
                   |Wrong size in the HiZ clear |Weird behavior with 3 pipes
                   |packet causes the zbuffer   |
                   |not to be fully cleared     |

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] [RADEON:KMS:R300G] HiZ: Weird behavior with 3 pipes
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (24 preceding siblings ...)
  2011-03-07 20:41 ` [Bug 32945] [RADEON:KMS:R300G] HiZ: Weird behavior with 3 pipes bugzilla-daemon
@ 2011-03-10 21:13 ` bugzilla-daemon
  2011-03-11  3:40 ` bugzilla-daemon
                   ` (2 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-03-10 21:13 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #23 from Nicolas Peninguy <npeninguy@gmail.com> 2011-03-10 13:13:28 PST ---
Created an attachment (id=44333)
 View: https://bugs.freedesktop.org/attachment.cgi?id=44333
 Review: https://bugs.freedesktop.org/review?bug=32945&attachment=44333

Possible fix

The attached patch fixes the issue with shadowtex for me. Sven, can you try it
and also see if doom3 is still OK with it ?

With 3 pipes values are NPOT, so align() is not suitable in some places I
think.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] [RADEON:KMS:R300G] HiZ: Weird behavior with 3 pipes
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (25 preceding siblings ...)
  2011-03-10 21:13 ` bugzilla-daemon
@ 2011-03-11  3:40 ` bugzilla-daemon
  2011-03-11 16:47 ` bugzilla-daemon
  2011-03-11 19:33 ` bugzilla-daemon
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-03-11  3:40 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #24 from Marek Olšák <maraeo@gmail.com> 2011-03-10 19:40:15 PST ---
(In reply to comment #23)
> Created an attachment (id=44333)
 View: https://bugs.freedesktop.org/attachment.cgi?id=44333
 Review: https://bugs.freedesktop.org/review?bug=32945&attachment=44333

> Possible fix
> 
> The attached patch fixes the issue with shadowtex for me. Sven, can you try it
> and also see if doom3 is still OK with it ?
> 
> With 3 pipes values are NPOT, so align() is not suitable in some places I
> think.

Pushed, thanks a lot!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] [RADEON:KMS:R300G] HiZ: Weird behavior with 3 pipes
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (26 preceding siblings ...)
  2011-03-11  3:40 ` bugzilla-daemon
@ 2011-03-11 16:47 ` bugzilla-daemon
  2011-03-11 19:33 ` bugzilla-daemon
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-03-11 16:47 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #25 from Sven Arvidsson <sa@whiz.se> 2011-03-11 08:47:47 PST ---
(In reply to comment #23)
> Created an attachment (id=44333)
 View: https://bugs.freedesktop.org/attachment.cgi?id=44333
 Review: https://bugs.freedesktop.org/review?bug=32945&attachment=44333

> Possible fix
> 
> The attached patch fixes the issue with shadowtex for me. Sven, can you try it
> and also see if doom3 is still OK with it ?
> 
> With 3 pipes values are NPOT, so align() is not suitable in some places I
> think.

Cool! This does indeed fix things!

The only remaining app with HiZ problems here is Lightsmark, but it seems to be
a general problem tracked in bug 33648.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [Bug 32945] [RADEON:KMS:R300G] HiZ: Weird behavior with 3 pipes
  2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
                   ` (27 preceding siblings ...)
  2011-03-11 16:47 ` bugzilla-daemon
@ 2011-03-11 19:33 ` bugzilla-daemon
  28 siblings, 0 replies; 30+ messages in thread
From: bugzilla-daemon @ 2011-03-11 19:33 UTC (permalink / raw)
  To: dri-devel

https://bugs.freedesktop.org/show_bug.cgi?id=32945

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #26 from Marek Olšák <maraeo@gmail.com> 2011-03-11 11:33:40 PST ---
(In reply to comment #25)
> Cool! This does indeed fix things!

Alright, closing.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, other threads:[~2011-03-11 19:33 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-09 21:55 [Bug 32945] New: Lower part of the screen corrupt with HyperZ enabled bugzilla-daemon
2011-01-09 23:07 ` [Bug 32945] " bugzilla-daemon
2011-01-10 16:00 ` bugzilla-daemon
2011-01-25  5:00 ` bugzilla-daemon
2011-01-25 14:32 ` bugzilla-daemon
2011-01-25 14:34 ` bugzilla-daemon
2011-01-25 15:54 ` bugzilla-daemon
2011-01-25 16:06 ` bugzilla-daemon
2011-01-25 16:33 ` bugzilla-daemon
2011-01-25 22:29 ` bugzilla-daemon
2011-01-25 22:55 ` bugzilla-daemon
2011-01-25 23:37 ` bugzilla-daemon
2011-01-26  0:38 ` bugzilla-daemon
2011-01-26 15:59 ` bugzilla-daemon
2011-01-28  0:10 ` bugzilla-daemon
2011-01-28 11:08 ` bugzilla-daemon
2011-01-28 12:38 ` bugzilla-daemon
2011-02-11  2:10 ` [Bug 32945] [r300g] HyperZ: Wrong size in the HiZ clear packet causes the zbuffer not to be fully cleared bugzilla-daemon
2011-03-01  0:34 ` bugzilla-daemon
2011-03-01 12:05 ` bugzilla-daemon
2011-03-01 12:06 ` bugzilla-daemon
2011-03-03 20:52 ` bugzilla-daemon
2011-03-06 22:07 ` bugzilla-daemon
2011-03-06 22:12 ` bugzilla-daemon
2011-03-07 20:01 ` [Bug 32945] [RADEON:KMS:R300G] " bugzilla-daemon
2011-03-07 20:41 ` [Bug 32945] [RADEON:KMS:R300G] HiZ: Weird behavior with 3 pipes bugzilla-daemon
2011-03-10 21:13 ` bugzilla-daemon
2011-03-11  3:40 ` bugzilla-daemon
2011-03-11 16:47 ` bugzilla-daemon
2011-03-11 19:33 ` bugzilla-daemon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.