From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/4] Makefile: generate CMake toolchain-file in $(O)
Date: Wed, 26 Jan 2011 00:21:13 +0100 [thread overview]
Message-ID: <20110126002113.51aeb0f0@surf> (raw)
In-Reply-To: <1295124808-5649-2-git-send-email-bjorn.forsman@gmail.com>
Hello Bjorn,
On Sat, 15 Jan 2011 21:53:25 +0100
Bj?rn Forsman <bjorn.forsman@gmail.com> wrote:
> + set(CMAKE_SYSTEM_NAME Linux)\n\
> + set(CMAKE_C_COMPILER $(CMAKE_TARGET_CC))\n\
> + set(CMAKE_CXX_COMPILER $(CMAKE_TARGET_CXX))\n\
> + set(CMAKE_C_FLAGS \"${CMAKE_C_FLAGS} $(CMAKE_TARGET_CFLAGS)\" CACHE STRING \"Buildroot CFLAGS\" FORCE)\n\
> + set(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} $(CMAKE_TARGET_CXXFLAGS)\" CACHE STRING \"Buildroot CXXFLAGS\" FORCE)\n\
> + set(CMAKE_INSTALL_SO_NO_EXE 0)\n\
> + set(CMAKE_PROGRAM_PATH \"$(HOST_DIR)/usr/bin\")\n\
> + set(CMAKE_FIND_ROOT_PATH \"$(STAGING_DIR)\")\n\
> + set(CMAKE_FIND_ROOT_PATH_MODE_PROGRAM NEVER)\n\
> + set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY)\n\
> + set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY)\n\
> + " > $@
Could you also add:
+ set(ENV{PKG_CONFIG_SYSROOT_DIR} $(STAGING_DIR))\n\
This is needed to get CMake pkg-config module to work properly.
I am not entirely happy with the name/location of the CMake toolchain
file, but that's something we can sort out later.
I have tested your patchset with my qserialport library (that uses
CMake as its build system and relies on Qt) and my custom application
(that uses CMake, Qt and qserialport), and it worked fine with the
PKG_CONFIG_SYSROOT_DIR change mentionned above.
So, once this change is done, your patch gets my:
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-01-25 23:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 20:53 [Buildroot] [PATCH v2 0/4] Introducing CMAKETARGETS infrastructure Bjørn Forsman
2011-01-15 20:53 ` [Buildroot] [PATCH v2 1/4] Makefile: generate CMake toolchain-file in $(O) Bjørn Forsman
2011-01-25 23:21 ` Thomas Petazzoni [this message]
2011-01-26 0:33 ` Bjørn Forsman
2011-01-26 7:47 ` Thomas Petazzoni
2011-01-15 20:53 ` [Buildroot] [PATCH v2 2/4] Add CMAKETARGETS infrastructure for CMake packages Bjørn Forsman
2011-01-23 13:30 ` Samuel Martin
2011-01-25 23:25 ` Thomas Petazzoni
2011-01-26 0:39 ` Bjørn Forsman
2011-01-15 20:53 ` [Buildroot] [PATCH v2 3/4] doc: add CMAKETARGETS documentation Bjørn Forsman
2011-01-15 20:53 ` [Buildroot] [PATCH v2 4/4] cdrkit: convert to CMAKETARGETS infrastructure Bjørn Forsman
2011-01-23 13:30 ` Samuel Martin
2011-01-23 14:42 ` Bjørn Forsman
2011-01-25 23:26 ` Thomas Petazzoni
2011-01-26 8:43 ` Thomas Petazzoni
2011-01-26 9:56 ` Bjørn Forsman
2011-01-22 11:54 ` [Buildroot] [PATCH v2 0/4] Introducing " Bjørn Forsman
2011-01-24 17:16 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126002113.51aeb0f0@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.