From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752795Ab1AZCxS (ORCPT ); Tue, 25 Jan 2011 21:53:18 -0500 Received: from kroah.org ([198.145.64.141]:52907 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752626Ab1AZCw7 (ORCPT ); Tue, 25 Jan 2011 21:52:59 -0500 Date: Wed, 26 Jan 2011 10:48:31 +0800 From: Greg KH To: Aaron Durbin Cc: Jeff Garzik , Mike Waychison , torvalds@linux-foundation.org, San Mehat , Duncan Laurie , linux-kernel@vger.kernel.org, Tim Hockin Subject: Re: [PATCH v1 1/6] Add oops notification chain. Message-ID: <20110126024831.GD28283@kroah.com> References: <20110125002433.12637.51091.stgit@mike.mtv.corp.google.com> <20110125002439.12637.8515.stgit@mike.mtv.corp.google.com> <20110125020658.GA3481@kroah.com> <4D3F4275.50709@garzik.org> <4D3F4699.60809@garzik.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 25, 2011 at 02:21:03PM -0800, Aaron Durbin wrote: > As Mike talked about it might be more desirable to actually pass a > reason field that indicates the appropriate kernel event. However, the > naming of some of the variables becomes less clear. Maybe name it > panic_oops_notifier_list? That way there would only be a single > notifier chain. Yes, I think that's the better thing to do here instead of adding more notifier chains. It would just start to get even messier than it currently is :) thanks, greg k-h