From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752880Ab1AZE0L (ORCPT <rfc822;w@1wt.eu>);
	Tue, 25 Jan 2011 23:26:11 -0500
Received: from mail-ww0-f44.google.com ([74.125.82.44]:41788 "EHLO
	mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752101Ab1AZE0I (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 25 Jan 2011 23:26:08 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:mail-followup-to:references
         :mime-version:content-type:content-disposition:in-reply-to
         :user-agent;
        b=vG62AZ6V0aC/94VfYPZw/kDgEacVLvJZmro2PYIcSFF0mh29qk8laUi+8CNms80xCr
         +yL3kaswrRfMq1rJVqGc5rPsbvw3aL+xMMEGN2rE68LL9uBdhWw9FIZrxlhqPozup0Kx
         lW9V0fxWi4A1khT51P6RhtMJSDWgaMutePXe8=
Date: Wed, 26 Jan 2011 07:25:51 +0300
From: Dan Carpenter <error27@gmail.com>
To: Julia Lawall <julia@diku.dk>
Cc: Peter Huewe <peterhuewe@gmx.de>,
        Mauro Carvalho Chehab <mchehab@infradead.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, Steven Toth <stoth@kernellabs.com>,
        Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] video/saa7164: Fix sparse warning: Using plain integer
 as NULL pointer
Message-ID: <20110126042551.GK2721@bicker>
Mail-Followup-To: Dan Carpenter <error27@gmail.com>,
	Julia Lawall <julia@diku.dk>, Peter Huewe <peterhuewe@gmx.de>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org, Steven Toth <stoth@kernellabs.com>,
	Tejun Heo <tj@kernel.org>
References: <1295988851-23561-1-git-send-email-peterhuewe@gmx.de>
 <Pine.LNX.4.64.1101252319570.3668@ask.diku.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.64.1101252319570.3668@ask.diku.dk>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 25, 2011 at 11:20:44PM +0100, Julia Lawall wrote:
> On Tue, 25 Jan 2011, Peter Huewe wrote:
> 
> > This patch fixes the warning "Using plain integer as NULL pointer",
> > generated by sparse, by replacing the offending 0s with NULL.
> I recall (a number of years ago) being told that for things like kmalloc, 
> the proper test was !x, not x == NULL.
> 

It was Al Viro who said that.  Here's the link.

http://lwn.net/Articles/331593/

regards,
dan carpenter


From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <error27@gmail.com>
Date: Wed, 26 Jan 2011 04:25:51 +0000
Subject: Re: [PATCH] video/saa7164: Fix sparse warning: Using plain integer
Message-Id: <20110126042551.GK2721@bicker>
List-Id: <kernel-janitors.vger.kernel.org>
References: <1295988851-23561-1-git-send-email-peterhuewe@gmx.de>
 <Pine.LNX.4.64.1101252319570.3668@ask.diku.dk>
In-Reply-To: <Pine.LNX.4.64.1101252319570.3668@ask.diku.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Julia Lawall <julia@diku.dk>
Cc: Peter Huewe <peterhuewe@gmx.de>, Mauro Carvalho Chehab <mchehab@infradead.org>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Steven Toth <stoth@kernellabs.com>, Tejun Heo <tj@kernel.org>

On Tue, Jan 25, 2011 at 11:20:44PM +0100, Julia Lawall wrote:
> On Tue, 25 Jan 2011, Peter Huewe wrote:
> 
> > This patch fixes the warning "Using plain integer as NULL pointer",
> > generated by sparse, by replacing the offending 0s with NULL.
> I recall (a number of years ago) being told that for things like kmalloc, 
> the proper test was !x, not x = NULL.
> 

It was Al Viro who said that.  Here's the link.

http://lwn.net/Articles/331593/

regards,
dan carpenter