From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 26 Jan 2011 08:39:30 +0100 Subject: [U-Boot] [PATCH V2 4/5] mvmfp: add MFP configuration support for PANTHEON In-Reply-To: References: <1294632087-8025-1-git-send-email-leiwen@marvell.com> <1294632087-8025-5-git-send-email-leiwen@marvell.com> <20110125213419.5C9431365DB@gemini.denx.de> Message-ID: <20110126073930.12A4CBB0B9@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Lei Wen, In message you wrote: > > >> This patch adds the support MFP support for Marvell PANTHEON SoCs > > > > "the support MFP support" ?? > > > > Please fix. Also, please explain what MFP is. It may be obvious to > > you, it ain't so for me. > > > >> +/* > >> + * Frequently used MFP Configuration macros for all PANTHEON family of > >> +SoCs > > > > Line wrapped - please fix. > > > > > This already fixed in the v6 patch, maybe you didn't notice this... > http://patchwork.ozlabs.org/patch/80307/ Only the line wrap was fixed. The other 2 remarks still apply. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I'm a programmer: I don't buy software, I write it. -- Tom Christiansen