From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 26 Jan 2011 09:06:44 +0100 Subject: [U-Boot] [PATCH V2 4/5] mvmfp: add MFP configuration support for PANTHEON In-Reply-To: References: <1294632087-8025-1-git-send-email-leiwen@marvell.com> <1294632087-8025-5-git-send-email-leiwen@marvell.com> <20110125213419.5C9431365DB@gemini.denx.de> <20110126073930.12A4CBB0B9@gemini.denx.de> Message-ID: <20110126080644.B5F75BB0B9@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Lei Wen, In message you wrote: > > >> > Please fix. Also, please explain what MFP is. It may be obvious to > >> > you, it ain't so for me. > > MFP is stand for multiply function pin setting, which servers for > setting a pin of cpu to server for different > functions on different design boards to better suit for its design. multiply or multiple? Maybe you can write something like "Add support for multiple function pin (MFP) for Marvell PANTHEON SoCs" in your commit message. Otherwise people might wonder what Multi Function Peripherals or Multi Function Printers have to do with that. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If I don't document something, it's usually either for a good reason, or a bad reason. In this case it's a good reason. :-) - Larry Wall in <1992Jan17.005405.16806@netlabs.com>