From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752802Ab1AZKrn (ORCPT ); Wed, 26 Jan 2011 05:47:43 -0500 Received: from cantor2.suse.de ([195.135.220.15]:53470 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159Ab1AZKrl (ORCPT ); Wed, 26 Jan 2011 05:47:41 -0500 Date: Wed, 26 Jan 2011 11:47:34 +0100 From: Jan Kara To: Tejun Heo Cc: "Darrick J. Wong" , Vivek Goyal , axboe@kernel.dk, tytso@mit.edu, shli@kernel.org, neilb@suse.de, adilger.kernel@dilger.ca, jack@suse.cz, snitzer@redhat.com, linux-kernel@vger.kernel.org, kmannth@us.ibm.com, cmm@us.ibm.com, linux-ext4@vger.kernel.org, rwheeler@redhat.com, hch@lst.de, josef@redhat.com Subject: Re: [PATCH 3/3] ext4: Deprecate barrier= and nobarrier mount options Message-ID: <20110126104734.GA23245@quack.suse.cz> References: <20110126071200.GE32261@tux1.beaverton.ibm.com> <20110126072329.GK27190@tux1.beaverton.ibm.com> <20110126093632.GB12520@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110126093632.GB12520@htj.dyndns.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed 26-01-11 10:36:32, Tejun Heo wrote: > On Tue, Jan 25, 2011 at 11:23:29PM -0800, Darrick J. Wong wrote: > > As part of migrating the FLUSH/FUA knob to the block layer, remove the support > > code for the barrier-related mount options and remove the conditionals around > > flushes in favor of always issuing the flush. The block layer will handle > > gracefully the situation where a FLUSH or FUA request is issued to a device > > that doesn't support it. Modify the option parsing code to print a warning if > > someone tries to use the old mount option. > > > > Note: The nobarrier bit in the default mount flags is now useless. > > The option is something which users are already quite familiar with. > I think we'll just have to carry this around. What we can do, tho, is > moving the actual control mechanism to block layer - > ie. blkdev_skip_flush() or something like that which ignores flush > requests for the current exclusive opener. Ted should have a final word about this but I believe it's possible to deprecate the mount options. Maybe with some transition period where deprecation message is shown but the option actually still works. That being said I'm not sure what we should do when someone has a disk with two partitions and one partition is mounted with barriers and another one without them - sure, one has to think hard to find a sane use case for this (possibly if user does not care about data after a crash on one of the partitions, in which case he should probably use nojournal mode) but it should probably work. Honza -- Jan Kara SUSE Labs, CR