All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] block: add block_resize monitor command
Date: Wed, 26 Jan 2011 09:56:37 -0200	[thread overview]
Message-ID: <20110126115637.GA25302@amt.cnet> (raw)
In-Reply-To: <20110125180537.GA4087@lst.de>

On Tue, Jan 25, 2011 at 07:05:37PM +0100, Christoph Hellwig wrote:
> On Tue, Jan 25, 2011 at 01:01:04PM +0100, Kevin Wolf wrote:
> > > Can't resize if block migration is in progress. Don't see a problem 
> > > with simply disallowing resize in that case.
> > 
> > Then we should add a check to bdrv_truncate.
> 
> What check exactly would that be anyway?

Need to add the information to BlockDriver state. drive_del is also
broken, it can be fixed later. Patch looks good to me.

  reply	other threads:[~2011-01-26 12:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 12:32 [Qemu-devel] [PATCH 0/3 v3] allow online resizing of block devices Christoph Hellwig
2011-01-24 12:32 ` [Qemu-devel] [PATCH 1/3] block: add block_resize monitor command Christoph Hellwig
2011-01-24 17:44   ` Marcelo Tosatti
2011-01-25 12:01     ` Kevin Wolf
2011-01-25 18:05       ` Christoph Hellwig
2011-01-26 11:56         ` Marcelo Tosatti [this message]
2011-01-24 12:32 ` [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize Christoph Hellwig
2011-01-24 12:32 ` [Qemu-devel] [PATCH 3/3] virtio-blk: tell the guest about size changes Christoph Hellwig
2011-01-26 10:32 ` [Qemu-devel] [PATCH 0/3 v3] allow online resizing of block devices Kevin Wolf
2011-01-26 10:49 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110126115637.GA25302@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.