From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56580 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pi43w-0003od-Ke
	for qemu-devel@nongnu.org; Wed, 26 Jan 2011 07:01:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1Pi43v-0006gC-Fd
	for qemu-devel@nongnu.org; Wed, 26 Jan 2011 07:01:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:13910)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1Pi43v-0006g0-8H
	for qemu-devel@nongnu.org; Wed, 26 Jan 2011 07:01:23 -0500
Date: Wed, 26 Jan 2011 09:56:37 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] block: add block_resize monitor command
Message-ID: <20110126115637.GA25302@amt.cnet>
References: <20110124123223.GA16558@lst.de> <20110124123233.GA16613@lst.de>
	<20110124174416.GA6178@amt.cnet> <4D3EBB80.1000107@redhat.com>
	<20110125180537.GA4087@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110125180537.GA4087@lst.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

On Tue, Jan 25, 2011 at 07:05:37PM +0100, Christoph Hellwig wrote:
> On Tue, Jan 25, 2011 at 01:01:04PM +0100, Kevin Wolf wrote:
> > > Can't resize if block migration is in progress. Don't see a problem 
> > > with simply disallowing resize in that case.
> > 
> > Then we should add a check to bdrv_truncate.
> 
> What check exactly would that be anyway?

Need to add the information to BlockDriver state. drive_del is also
broken, it can be fixed later. Patch looks good to me.