From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC 00/20] Proposal for remaining BKL users Date: Wed, 26 Jan 2011 14:45:17 +0100 Message-ID: <201101261445.17751.arnd@arndb.de> References: <1295993854-4971-1-git-send-email-arnd@arndb.de> <201101261231.30390.arnd@arndb.de> <4D400C5D.80004@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Frederic Weisbecker , dri-devel@lists.freedesktop.org, Mikulas Patocka , "H. Peter Anvin" , Ian Kent , linux-cifs@vger.kernel.org, Nick Bowler , linux-x25@vger.kernel.org, Takahiro Hirofuchi , Ross Cohen , Arnaldo Carvalho de Melo , Evgeniy Dushistov , Stuart Swales , Thomas Gleixner , Arjan van de Ven , autofs@linux.kernel.org, Jeff Layton , netdev@vger.kernel.org, Greg KH , linux-kernel@vger.kernel.org, Palash Bandyopadhyay , linux-fsdevel@vger.kernel.org, Andrew Morton , Andrew Hendry To: Mauro Carvalho Chehab Return-path: In-Reply-To: <4D400C5D.80004@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org List-Id: linux-cifs.vger.kernel.org On Wednesday 26 January 2011, Mauro Carvalho Chehab wrote: > I guess you're meaning cx25821, right? Right, sorry for the typo. > Palash should take a look on it and review. This is a device that allows > 12 simultaneous streams, so, I suspect that he'll need to do some > changes at the locking schema, to avoid performance bottlenecks. I would be surprised if there was any measurable performance change. The BKL was used only in the open() function to iterate the device list, and that code is nowhere on a critical path, as far as I can tell. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC 00/20] Proposal for remaining BKL users Date: Wed, 26 Jan 2011 14:45:17 +0100 Message-ID: <201101261445.17751.arnd@arndb.de> References: <1295993854-4971-1-git-send-email-arnd@arndb.de> <201101261231.30390.arnd@arndb.de> <4D400C5D.80004@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.187]) by gabe.freedesktop.org (Postfix) with ESMTP id 10B979E764 for ; Wed, 26 Jan 2011 05:46:00 -0800 (PST) In-Reply-To: <4D400C5D.80004@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Mauro Carvalho Chehab Cc: Frederic Weisbecker , dri-devel@lists.freedesktop.org, Mikulas Patocka , "H. Peter Anvin" , Ian Kent , linux-cifs@vger.kernel.org, Nick Bowler , linux-x25@vger.kernel.org, Takahiro Hirofuchi , Ross Cohen , Arnaldo Carvalho de Melo , Evgeniy Dushistov , Stuart Swales , Thomas Gleixner , Arjan van de Ven , autofs@linux.kernel.org, Jeff Layton , netdev@vger.kernel.org, Greg KH , linux-kernel@vger.kernel.org, Palash Bandyopadhyay , linux-fsdevel@vger.kernel.org, Andrew Morton Andrew List-Id: dri-devel@lists.freedesktop.org On Wednesday 26 January 2011, Mauro Carvalho Chehab wrote: > I guess you're meaning cx25821, right? Right, sorry for the typo. > Palash should take a look on it and review. This is a device that allows > 12 simultaneous streams, so, I suspect that he'll need to do some > changes at the locking schema, to avoid performance bottlenecks. I would be surprised if there was any measurable performance change. The BKL was used only in the open() function to iterate the device list, and that code is nowhere on a critical path, as far as I can tell. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC 00/20] Proposal for remaining BKL users Date: Wed, 26 Jan 2011 14:45:17 +0100 Message-ID: <201101261445.17751.arnd@arndb.de> References: <1295993854-4971-1-git-send-email-arnd@arndb.de> <201101261231.30390.arnd@arndb.de> <4D400C5D.80004@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4D400C5D.80004@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Mauro Carvalho Chehab Cc: Frederic Weisbecker , dri-devel@lists.freedesktop.org, Mikulas Patocka , "H. Peter Anvin" , Ian Kent , linux-cifs@vger.kernel.org, Nick Bowler , linux-x25@vger.kernel.org, Takahiro Hirofuchi , Ross Cohen , Arnaldo Carvalho de Melo , Evgeniy Dushistov , Stuart Swales , Thomas Gleixner , Arjan van de Ven , autofs@linux.kernel.org, Jeff Layton , netdev@vger.kernel.org, Greg KH , linux-kernel@vger.kernel.org, Palash Bandyopadhyay , linux-fsdevel@vger.kernel.org, Andrew Morton , Andrew On Wednesday 26 January 2011, Mauro Carvalho Chehab wrote: > I guess you're meaning cx25821, right? Right, sorry for the typo. > Palash should take a look on it and review. This is a device that allows > 12 simultaneous streams, so, I suspect that he'll need to do some > changes at the locking schema, to avoid performance bottlenecks. I would be surprised if there was any measurable performance change. The BKL was used only in the open() function to iterate the device list, and that code is nowhere on a critical path, as far as I can tell. Arnd