All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Gordeev <lasaine@lvk.cs.msu.su>
To: tmarri@apm.com
Cc: greg@kroah.com, linux-usb@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, Fushen Chen <fchen@apm.com>,
	Mark Miesfeld <mmiesfeld@apm.com>
Subject: Re: [PATCH V8 04/10] USB/ppc4xx: Add Synopsys DWC OTG HCD function
Date: Wed, 26 Jan 2011 19:27:43 +0300	[thread overview]
Message-ID: <20110126192743.646af6d2@desktopvm.lvknet> (raw)
In-Reply-To: <1295477855-14775-1-git-send-email-tmarri@apm.com>

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

Hi,

Please consider squashing this little patch into yours. The driver
currently prints 0x00000000 as the register base. This patch will fix
that.

commit 2f850fe637101be287f116a37282b6b1a09e6a98
Author: Alexander Gordeev <lasaine@lvk.cs.msu.su>
Date:   Mon Nov 29 15:15:25 2010 +0300

    dwc_otg: set usb hcd resource address and length
    
    Signed-off-by: Alexander Gordeev <lasaine@lvk.cs.msu.su>

diff --git a/drivers/usb/dwc_otg/dwc_otg_hcd.c b/drivers/usb/dwc_otg/dwc_otg_hcd.c
index 240ab0b..e420a8d 100644
--- a/drivers/usb/dwc_otg/dwc_otg_hcd.c
+++ b/drivers/usb/dwc_otg/dwc_otg_hcd.c
@@ -1269,6 +1269,8 @@ int __devinit dwc_otg_hcd_init(struct device *_dev,
 	}
 	dev_set_drvdata(_dev, dwc_otg_device);
 	hcd->regs = otg_dev->base;
+	hcd->rsrc_start = otg_dev->phys_addr;
+	hcd->rsrc_len = otg_dev->base_len;
 	hcd->self.otg_port = 1;
 
 	/* Initialize the DWC OTG HCD. */

-- 
  Alexander

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2011-01-26 16:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19 22:57 [PATCH V8 04/10] USB/ppc4xx: Add Synopsys DWC OTG HCD function tmarri
2011-01-26 16:27 ` Alexander Gordeev [this message]
2011-02-07 18:53   ` Tirumala Marri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110126192743.646af6d2@desktopvm.lvknet \
    --to=lasaine@lvk.cs.msu.su \
    --cc=fchen@apm.com \
    --cc=greg@kroah.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mmiesfeld@apm.com \
    --cc=tmarri@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.