From: Gustavo F. Padovan <padovan@profusion.mobi>
To: ofono@ofono.org
Subject: Re: [PATCH v3 2/7] gps: add gps atom and gpsagent implementations
Date: Wed, 26 Jan 2011 20:13:31 -0200 [thread overview]
Message-ID: <20110126221331.GC2192@joana> (raw)
In-Reply-To: <20110126221146.GB18330@nodo3>
[-- Attachment #1: Type: text/plain, Size: 1762 bytes --]
* Rafael Ignacio Zurita <rafael.zurita@profusion.mobi> [2011-01-26 19:11:46 -0300]:
> Hi Gustavo,
>
> On Wed, Jan 26, 2011 at 07:51:57PM -0200, Gustavo F. Padovan wrote:
> > Hi Rafael,
> >
> > * Rafael Ignacio Zurita <rafael.zurita@profusion.mobi> [2011-01-26 12:32:49 -0300]:
> >
> > > ---
> > > Makefile.am | 3 +-
> > > src/gps.c | 326 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > src/gpsagent.c | 145 +++++++++++++++++++++++++
> > > src/gpsagent.h | 37 +++++++
> > > src/ofono.conf | 1 +
> > > src/ofono.h | 2 +
> > > 6 files changed, 513 insertions(+), 1 deletions(-)
> > > create mode 100644 src/gps.c
> > > create mode 100644 src/gpsagent.c
> > > create mode 100644 src/gpsagent.h
> > >
> > > diff --git a/Makefile.am b/Makefile.am
> > > index 7374f70..de70976 100644
> > > --- a/Makefile.am
> > > +++ b/Makefile.am
> > > @@ -355,7 +355,8 @@ src_ofonod_SOURCES = $(gdbus_sources) $(builtin_sources) src/ofono.ver \
> > > src/simfs.c src/simfs.h src/audio-settings.c \
> > > src/smsagent.c src/smsagent.h src/ctm.c \
> > > src/cdma-voicecall.c src/sim-auth.c \
> > > - src/message.h src/message.c
> > > + src/message.h src/message.c src/gps.c \
> > > + src/gpsagent.c src/gpsagent.h
> >
> > gpsagent.c should not be in src/, it should be in test/. But I saw you already
> > have python implementation for the Agent. So just discard the c one and keep
> > only the python one. oFono does not really care about the Agent
> > implementation.
>
> I am not understanding your comments. gpsagent.c here is not a test.
> It is similar to stkagent or smsagent.
Yeah, because they are wrong. :(
--
Gustavo F. Padovan
http://profusion.mobi
next prev parent reply other threads:[~2011-01-26 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 15:32 [PATCH v3 0/7] Add GPS atom Rafael Ignacio Zurita
2011-01-26 15:32 ` [PATCH v3 1/7] gps: add public header Rafael Ignacio Zurita
2011-01-26 15:32 ` [PATCH v3 2/7] gps: add gps atom and gpsagent implementations Rafael Ignacio Zurita
2011-01-26 21:51 ` Gustavo F. Padovan
2011-01-26 22:11 ` Rafael Ignacio Zurita
2011-01-26 22:13 ` Gustavo F. Padovan [this message]
2011-01-26 15:32 ` [PATCH v3 3/7] mbmmodem: add gps atom Rafael Ignacio Zurita
2011-01-26 15:32 ` [PATCH v3 4/7] plugins: add gps atom to mbm Rafael Ignacio Zurita
2011-01-26 15:32 ` [PATCH v3 5/7] plugins/udev.c: add gps comparison for add_mbm registered modem Rafael Ignacio Zurita
2011-01-26 15:32 ` [PATCH v3 6/7] gps: add test script Rafael Ignacio Zurita
2011-01-26 15:32 ` [PATCH v3 7/7] gps: add documentation Rafael Ignacio Zurita
2011-01-26 21:47 ` Gustavo F. Padovan
2011-01-26 22:10 ` Rafael Ignacio Zurita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126221331.GC2192@joana \
--to=padovan@profusion.mobi \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.