From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41376 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PiMLJ-0007Xc-Ks for qemu-devel@nongnu.org; Thu, 27 Jan 2011 02:32:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PiMLI-0002Jw-Kh for qemu-devel@nongnu.org; Thu, 27 Jan 2011 02:32:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PiMLI-0002Je-Ar for qemu-devel@nongnu.org; Thu, 27 Jan 2011 02:32:32 -0500 Date: Thu, 27 Jan 2011 09:32:15 +0200 From: "Michael S. Tsirkin" Message-ID: <20110127073215.GC28784@redhat.com> References: <4dfae7d2e88a4459b24dfc60d07bfb5e55963545.1296111201.git.yamahata@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4dfae7d2e88a4459b24dfc60d07bfb5e55963545.1296111201.git.yamahata@valinux.co.jp> Subject: [Qemu-devel] Re: [PATCH v2 5/5] pci: use uint8_t for devfn_min List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: qemu-devel@nongnu.org On Thu, Jan 27, 2011 at 03:56:39PM +0900, Isaku Yamahata wrote: > use uint8_t for devfn_min instead of int. > > Signed-off-by: Isaku Yamahata Applied, thanks. > --- > hw/pci.c | 6 +++--- > hw/pci.h | 6 +++--- > hw/pci_internals.h | 2 +- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index e25bf7a..6725f50 100644 > --- a/hw/pci.c > +++ b/hw/pci.c > @@ -256,7 +256,7 @@ int pci_find_domain(const PCIBus *bus) > } > > void pci_bus_new_inplace(PCIBus *bus, DeviceState *parent, > - const char *name, int devfn_min) > + const char *name, uint8_t devfn_min) > { > qbus_create_inplace(&bus->qbus, &pci_bus_info, parent, name); > assert(PCI_FUNC(devfn_min) == 0); > @@ -269,7 +269,7 @@ void pci_bus_new_inplace(PCIBus *bus, DeviceState *parent, > vmstate_register(NULL, -1, &vmstate_pcibus, bus); > } > > -PCIBus *pci_bus_new(DeviceState *parent, const char *name, int devfn_min) > +PCIBus *pci_bus_new(DeviceState *parent, const char *name, uint8_t devfn_min) > { > PCIBus *bus; > > @@ -303,7 +303,7 @@ void pci_bus_set_mem_base(PCIBus *bus, target_phys_addr_t base) > > PCIBus *pci_register_bus(DeviceState *parent, const char *name, > pci_set_irq_fn set_irq, pci_map_irq_fn map_irq, > - void *irq_opaque, int devfn_min, int nirq) > + void *irq_opaque, uint8_t devfn_min, int nirq) > { > PCIBus *bus; > > diff --git a/hw/pci.h b/hw/pci.h > index 2266a47..2af709a 100644 > --- a/hw/pci.h > +++ b/hw/pci.h > @@ -230,14 +230,14 @@ typedef enum { > typedef int (*pci_hotplug_fn)(DeviceState *qdev, PCIDevice *pci_dev, > PCIHotplugState state); > void pci_bus_new_inplace(PCIBus *bus, DeviceState *parent, > - const char *name, int devfn_min); > -PCIBus *pci_bus_new(DeviceState *parent, const char *name, int devfn_min); > + const char *name, uint8_t devfn_min); > +PCIBus *pci_bus_new(DeviceState *parent, const char *name, uint8_t devfn_min); > void pci_bus_irqs(PCIBus *bus, pci_set_irq_fn set_irq, pci_map_irq_fn map_irq, > void *irq_opaque, int nirq); > void pci_bus_hotplug(PCIBus *bus, pci_hotplug_fn hotplug, DeviceState *dev); > PCIBus *pci_register_bus(DeviceState *parent, const char *name, > pci_set_irq_fn set_irq, pci_map_irq_fn map_irq, > - void *irq_opaque, int devfn_min, int nirq); > + void *irq_opaque, uint8_t devfn_min, int nirq); > void pci_device_reset(PCIDevice *dev); > void pci_bus_reset(PCIBus *bus); > > diff --git a/hw/pci_internals.h b/hw/pci_internals.h > index efaefcd..fbe1866 100644 > --- a/hw/pci_internals.h > +++ b/hw/pci_internals.h > @@ -16,7 +16,7 @@ extern struct BusInfo pci_bus_info; > > struct PCIBus { > BusState qbus; > - int devfn_min; > + uint8_t devfn_min; > pci_set_irq_fn set_irq; > pci_map_irq_fn map_irq; > pci_hotplug_fn hotplug; > -- > 1.7.1.1