Re: [PATCH - [hdspm] RayDAT/AIO 1/2] ALSA: Add support for RME RayDAT and AIO

[Adrian Knoth <adi@drcomp.erfurt.thur.de>]

On Thu, Jan 27, 2011 at 09:09:05AM +0100, Jaroslav Kysela wrote:

>>> +char channel_map_unity_ss[HDSPM_MAX_CHANNELS] = {
>>
>> Err, no, array definitions should be never in a header file.
>> It doesn't matter whether it's static or not.  The definition should
>> be in *.c file where it's used.

We have more than one C file using this information...

>> So, simply move these array definitions to hdspm.c.
>
> I think that the reason is to share these arrays with hdspmixer.

Exactly. hdspmixer needs this information, too. If we move it to the C
file, we would need to duplicate the information in hdspmixer. And then
we forget about it next time hdspm.h needs to be updated.


> But I agree, that it's better to move these static values to .c files.

Ok, I've sent a follow-up patch to avoid to send the whole 180k patch
for the 4th time.

I'll now duplicate this information and send a patch against hdspmixer.
I feel that there should be a better solution like getting the channel
mapping from the driver (sysfs, proc, ioctl or whatever), but that's for
some other time.


HTH

-- 
mail: adi@thur.de  	http://adi.thur.de	PGP/GPG: key via keyserver