All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd
@ 2011-01-25 15:08 Fabio Estevam
  2011-01-25 15:08 ` [PATCH 2/3] ARM: mach-mx5/board-mx53_loco: Make UART1 functional Fabio Estevam
                   ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Fabio Estevam @ 2011-01-25 15:08 UTC (permalink / raw)
  To: linux-arm-kernel

Commit 816ad74 (ARM: i.MX53: Add full iomux support for mx53) renamed some of the pad names.

Make the changes accordingly so that mx53_loco and mx53_cmd can build without errors.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/mach-mx5/board-mx53_loco.c |   25 +++++++++++++------------
 arch/arm/mach-mx5/board-mx53_smd.c  |   24 ++++++++++++------------
 2 files changed, 25 insertions(+), 24 deletions(-)

diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c
index d1348e0..dadc856 100644
--- a/arch/arm/mach-mx5/board-mx53_loco.c
+++ b/arch/arm/mach-mx5/board-mx53_loco.c
@@ -39,20 +39,21 @@
 #define LOCO_FEC_PHY_RST		IMX_GPIO_NR(7, 6)
 
 static iomux_v3_cfg_t mx53_loco_pads[] = {
-	MX53_PAD_CSI0_D10__UART1_TXD,
-	MX53_PAD_CSI0_D11__UART1_RXD,
-	MX53_PAD_ATA_DIOW__UART1_TXD,
-	MX53_PAD_ATA_DMACK__UART1_RXD,
-
-	MX53_PAD_ATA_BUFFER_EN__UART2_RXD,
-	MX53_PAD_ATA_DMARQ__UART2_TXD,
-	MX53_PAD_ATA_DIOR__UART2_RTS,
-	MX53_PAD_ATA_INTRQ__UART2_CTS,
-
-	MX53_PAD_ATA_CS_0__UART3_TXD,
-	MX53_PAD_ATA_CS_1__UART3_RXD,
-	MX53_PAD_ATA_DA_1__UART3_CTS,
-	MX53_PAD_ATA_DA_2__UART3_RTS,
+	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
+	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
+	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
+	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
+
+	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
+	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
+	MX53_PAD_PATA_DIOR__UART2_RTS,
+	MX53_PAD_PATA_INTRQ__UART2_CTS,
+
+	MX53_PAD_PATA_CS_0__UART3_TXD_MUX,
+	MX53_PAD_PATA_CS_1__UART3_RXD_MUX,
+	MX53_PAD_PATA_DA_1__UART3_CTS,
+	MX53_PAD_PATA_DA_2__UART3_RTS,
+
 };
 
 static const struct imxuart_platform_data mx53_loco_uart_data __initconst = {
diff --git a/arch/arm/mach-mx5/board-mx53_smd.c b/arch/arm/mach-mx5/board-mx53_smd.c
index 7970f7a..06070c5 100644
--- a/arch/arm/mach-mx5/board-mx53_smd.c
+++ b/arch/arm/mach-mx5/board-mx53_smd.c
@@ -39,20 +39,20 @@
 #define SMD_FEC_PHY_RST		IMX_GPIO_NR(7, 6)
 
 static iomux_v3_cfg_t mx53_smd_pads[] = {
-	MX53_PAD_CSI0_D10__UART1_TXD,
-	MX53_PAD_CSI0_D11__UART1_RXD,
-	MX53_PAD_ATA_DIOW__UART1_TXD,
-	MX53_PAD_ATA_DMACK__UART1_RXD,
-
-	MX53_PAD_ATA_BUFFER_EN__UART2_RXD,
-	MX53_PAD_ATA_DMARQ__UART2_TXD,
-	MX53_PAD_ATA_DIOR__UART2_RTS,
-	MX53_PAD_ATA_INTRQ__UART2_CTS,
-
-	MX53_PAD_ATA_CS_0__UART3_TXD,
-	MX53_PAD_ATA_CS_1__UART3_RXD,
-	MX53_PAD_ATA_DA_1__UART3_CTS,
-	MX53_PAD_ATA_DA_2__UART3_RTS,
+	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
+	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
+	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
+	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
+
+	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
+	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
+	MX53_PAD_PATA_DIOR__UART2_RTS,
+	MX53_PAD_PATA_INTRQ__UART2_CTS,
+
+	MX53_PAD_PATA_CS_0__UART3_TXD_MUX,
+	MX53_PAD_PATA_CS_1__UART3_RXD_MUX,
+	MX53_PAD_PATA_DA_1__UART3_CTS,
+	MX53_PAD_PATA_DA_2__UART3_RTS,
 };
 
 static const struct imxuart_platform_data mx53_smd_uart_data __initconst = {
-- 
1.6.0.4

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 2/3] ARM: mach-mx5/board-mx53_loco: Make UART1 functional
  2011-01-25 15:08 [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd Fabio Estevam
@ 2011-01-25 15:08 ` Fabio Estevam
  2011-01-25 15:08   ` [PATCH 3/3] ARM: mach-mx5/board-mx53_loco: Remove unused UARTs Fabio Estevam
  2011-01-28 12:48   ` [PATCH 2/3] ARM: mach-mx5/board-mx53_loco: Make UART1 functional Richard Zhao
  2011-01-27  7:30 ` [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd Sascha Hauer
  2011-01-28 12:46 ` Richard Zhao
  2 siblings, 2 replies; 15+ messages in thread
From: Fabio Estevam @ 2011-01-25 15:08 UTC (permalink / raw)
  To: linux-arm-kernel

Fix IOMUX settings for UART1 and make UART1 functional.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/mach-mx5/board-mx53_loco.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c
index dadc856..cba4cd5 100644
--- a/arch/arm/mach-mx5/board-mx53_loco.c
+++ b/arch/arm/mach-mx5/board-mx53_loco.c
@@ -41,8 +41,6 @@
 static iomux_v3_cfg_t mx53_loco_pads[] = {
 	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
 	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
-	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
-	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
 
 	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
 	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
@@ -62,7 +60,7 @@ static const struct imxuart_platform_data mx53_loco_uart_data __initconst = {
 
 static inline void mx53_loco_init_uart(void)
 {
-	imx53_add_imx_uart(0, &mx53_loco_uart_data);
+	imx53_add_imx_uart(0, NULL);
 	imx53_add_imx_uart(1, &mx53_loco_uart_data);
 	imx53_add_imx_uart(2, &mx53_loco_uart_data);
 }
-- 
1.6.0.4

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 3/3] ARM: mach-mx5/board-mx53_loco: Remove unused UARTs
  2011-01-25 15:08 ` [PATCH 2/3] ARM: mach-mx5/board-mx53_loco: Make UART1 functional Fabio Estevam
@ 2011-01-25 15:08   ` Fabio Estevam
  2011-01-28 12:48     ` Richard Zhao
  2011-01-28 12:48   ` [PATCH 2/3] ARM: mach-mx5/board-mx53_loco: Make UART1 functional Richard Zhao
  1 sibling, 1 reply; 15+ messages in thread
From: Fabio Estevam @ 2011-01-25 15:08 UTC (permalink / raw)
  To: linux-arm-kernel

On mx53_loco only UART1 is used and its signals go to connector J16.

Remove UART2 and UART3 as they are not used on this board.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/mach-mx5/board-mx53_loco.c |   24 +-----------------------
 1 files changed, 1 insertions(+), 23 deletions(-)

diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c
index cba4cd5..3aefd6d 100644
--- a/arch/arm/mach-mx5/board-mx53_loco.c
+++ b/arch/arm/mach-mx5/board-mx53_loco.c
@@ -41,30 +41,8 @@
 static iomux_v3_cfg_t mx53_loco_pads[] = {
 	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
 	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
-
-	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
-	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
-	MX53_PAD_PATA_DIOR__UART2_RTS,
-	MX53_PAD_PATA_INTRQ__UART2_CTS,
-
-	MX53_PAD_PATA_CS_0__UART3_TXD_MUX,
-	MX53_PAD_PATA_CS_1__UART3_RXD_MUX,
-	MX53_PAD_PATA_DA_1__UART3_CTS,
-	MX53_PAD_PATA_DA_2__UART3_RTS,
-
-};
-
-static const struct imxuart_platform_data mx53_loco_uart_data __initconst = {
-	.flags = IMXUART_HAVE_RTSCTS,
 };
 
-static inline void mx53_loco_init_uart(void)
-{
-	imx53_add_imx_uart(0, NULL);
-	imx53_add_imx_uart(1, &mx53_loco_uart_data);
-	imx53_add_imx_uart(2, &mx53_loco_uart_data);
-}
-
 static inline void mx53_loco_fec_reset(void)
 {
 	int ret;
@@ -88,7 +66,7 @@ static void __init mx53_loco_board_init(void)
 {
 	mxc_iomux_v3_setup_multiple_pads(mx53_loco_pads,
 					ARRAY_SIZE(mx53_loco_pads));
-	mx53_loco_init_uart();
+	imx53_add_imx_uart(0, NULL);
 	mx53_loco_fec_reset();
 	imx53_add_fec(&mx53_loco_fec_data);
 }
-- 
1.6.0.4

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd
  2011-01-25 15:08 [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd Fabio Estevam
  2011-01-25 15:08 ` [PATCH 2/3] ARM: mach-mx5/board-mx53_loco: Make UART1 functional Fabio Estevam
@ 2011-01-27  7:30 ` Sascha Hauer
  2011-01-27  9:30   ` Richard Zhao
  2011-01-28 12:46 ` Richard Zhao
  2 siblings, 1 reply; 15+ messages in thread
From: Sascha Hauer @ 2011-01-27  7:30 UTC (permalink / raw)
  To: linux-arm-kernel

Yong,

Can you ack these?

Sascha

On Tue, Jan 25, 2011 at 01:08:33PM -0200, Fabio Estevam wrote:
> Commit 816ad74 (ARM: i.MX53: Add full iomux support for mx53) renamed some of the pad names.
> 
> Make the changes accordingly so that mx53_loco and mx53_cmd can build without errors.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/mach-mx5/board-mx53_loco.c |   25 +++++++++++++------------
>  arch/arm/mach-mx5/board-mx53_smd.c  |   24 ++++++++++++------------
>  2 files changed, 25 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c
> index d1348e0..dadc856 100644
> --- a/arch/arm/mach-mx5/board-mx53_loco.c
> +++ b/arch/arm/mach-mx5/board-mx53_loco.c
> @@ -39,20 +39,21 @@
>  #define LOCO_FEC_PHY_RST		IMX_GPIO_NR(7, 6)
>  
>  static iomux_v3_cfg_t mx53_loco_pads[] = {
> -	MX53_PAD_CSI0_D10__UART1_TXD,
> -	MX53_PAD_CSI0_D11__UART1_RXD,
> -	MX53_PAD_ATA_DIOW__UART1_TXD,
> -	MX53_PAD_ATA_DMACK__UART1_RXD,
> -
> -	MX53_PAD_ATA_BUFFER_EN__UART2_RXD,
> -	MX53_PAD_ATA_DMARQ__UART2_TXD,
> -	MX53_PAD_ATA_DIOR__UART2_RTS,
> -	MX53_PAD_ATA_INTRQ__UART2_CTS,
> -
> -	MX53_PAD_ATA_CS_0__UART3_TXD,
> -	MX53_PAD_ATA_CS_1__UART3_RXD,
> -	MX53_PAD_ATA_DA_1__UART3_CTS,
> -	MX53_PAD_ATA_DA_2__UART3_RTS,
> +	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
> +	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
> +	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
> +	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
> +
> +	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
> +	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
> +	MX53_PAD_PATA_DIOR__UART2_RTS,
> +	MX53_PAD_PATA_INTRQ__UART2_CTS,
> +
> +	MX53_PAD_PATA_CS_0__UART3_TXD_MUX,
> +	MX53_PAD_PATA_CS_1__UART3_RXD_MUX,
> +	MX53_PAD_PATA_DA_1__UART3_CTS,
> +	MX53_PAD_PATA_DA_2__UART3_RTS,
> +
>  };
>  
>  static const struct imxuart_platform_data mx53_loco_uart_data __initconst = {
> diff --git a/arch/arm/mach-mx5/board-mx53_smd.c b/arch/arm/mach-mx5/board-mx53_smd.c
> index 7970f7a..06070c5 100644
> --- a/arch/arm/mach-mx5/board-mx53_smd.c
> +++ b/arch/arm/mach-mx5/board-mx53_smd.c
> @@ -39,20 +39,20 @@
>  #define SMD_FEC_PHY_RST		IMX_GPIO_NR(7, 6)
>  
>  static iomux_v3_cfg_t mx53_smd_pads[] = {
> -	MX53_PAD_CSI0_D10__UART1_TXD,
> -	MX53_PAD_CSI0_D11__UART1_RXD,
> -	MX53_PAD_ATA_DIOW__UART1_TXD,
> -	MX53_PAD_ATA_DMACK__UART1_RXD,
> -
> -	MX53_PAD_ATA_BUFFER_EN__UART2_RXD,
> -	MX53_PAD_ATA_DMARQ__UART2_TXD,
> -	MX53_PAD_ATA_DIOR__UART2_RTS,
> -	MX53_PAD_ATA_INTRQ__UART2_CTS,
> -
> -	MX53_PAD_ATA_CS_0__UART3_TXD,
> -	MX53_PAD_ATA_CS_1__UART3_RXD,
> -	MX53_PAD_ATA_DA_1__UART3_CTS,
> -	MX53_PAD_ATA_DA_2__UART3_RTS,
> +	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
> +	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
> +	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
> +	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
> +
> +	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
> +	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
> +	MX53_PAD_PATA_DIOR__UART2_RTS,
> +	MX53_PAD_PATA_INTRQ__UART2_CTS,
> +
> +	MX53_PAD_PATA_CS_0__UART3_TXD_MUX,
> +	MX53_PAD_PATA_CS_1__UART3_RXD_MUX,
> +	MX53_PAD_PATA_DA_1__UART3_CTS,
> +	MX53_PAD_PATA_DA_2__UART3_RTS,
>  };
>  
>  static const struct imxuart_platform_data mx53_smd_uart_data __initconst = {
> -- 
> 1.6.0.4
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd
  2011-01-27  7:30 ` [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd Sascha Hauer
@ 2011-01-27  9:30   ` Richard Zhao
  2011-01-27 11:48     ` Fabio Estevam
  0 siblings, 1 reply; 15+ messages in thread
From: Richard Zhao @ 2011-01-27  9:30 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Fabio,

Sorry I didn't see your patch. I just sent out a patch to include all pad
configure for imx53_loco.

I have some comments below.

On Thu, Jan 27, 2011 at 08:30:09AM +0100, Sascha Hauer wrote:
> Yong,
> 
> Can you ack these?
> 
> Sascha
> 
> On Tue, Jan 25, 2011 at 01:08:33PM -0200, Fabio Estevam wrote:
> > Commit 816ad74 (ARM: i.MX53: Add full iomux support for mx53) renamed some of the pad names.
> > 
> > Make the changes accordingly so that mx53_loco and mx53_cmd can build without errors.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> >  arch/arm/mach-mx5/board-mx53_loco.c |   25 +++++++++++++------------
> >  arch/arm/mach-mx5/board-mx53_smd.c  |   24 ++++++++++++------------
> >  2 files changed, 25 insertions(+), 24 deletions(-)
> > 
> > diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c
> > index d1348e0..dadc856 100644
> > --- a/arch/arm/mach-mx5/board-mx53_loco.c
> > +++ b/arch/arm/mach-mx5/board-mx53_loco.c
> > @@ -39,20 +39,21 @@
> >  #define LOCO_FEC_PHY_RST		IMX_GPIO_NR(7, 6)
> >  
> >  static iomux_v3_cfg_t mx53_loco_pads[] = {
> > -	MX53_PAD_CSI0_D10__UART1_TXD,
> > -	MX53_PAD_CSI0_D11__UART1_RXD,
> > -	MX53_PAD_ATA_DIOW__UART1_TXD,
> > -	MX53_PAD_ATA_DMACK__UART1_RXD,
> > -
> > -	MX53_PAD_ATA_BUFFER_EN__UART2_RXD,
> > -	MX53_PAD_ATA_DMARQ__UART2_TXD,
> > -	MX53_PAD_ATA_DIOR__UART2_RTS,
> > -	MX53_PAD_ATA_INTRQ__UART2_CTS,
> > -
> > -	MX53_PAD_ATA_CS_0__UART3_TXD,
> > -	MX53_PAD_ATA_CS_1__UART3_RXD,
> > -	MX53_PAD_ATA_DA_1__UART3_CTS,
> > -	MX53_PAD_ATA_DA_2__UART3_RTS,
> > +	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
> > +	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
> > +	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
> > +	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
So many Pad configured to uart1?
> > +
> > +	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
> > +	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
> > +	MX53_PAD_PATA_DIOR__UART2_RTS,
> > +	MX53_PAD_PATA_INTRQ__UART2_CTS,
> > +
> > +	MX53_PAD_PATA_CS_0__UART3_TXD_MUX,
> > +	MX53_PAD_PATA_CS_1__UART3_RXD_MUX,
> > +	MX53_PAD_PATA_DA_1__UART3_CTS,
> > +	MX53_PAD_PATA_DA_2__UART3_RTS,
LoCo don't have uart2 and uart3.
> > +
> >  };
> >  
> >  static const struct imxuart_platform_data mx53_loco_uart_data __initconst = {
> > diff --git a/arch/arm/mach-mx5/board-mx53_smd.c b/arch/arm/mach-mx5/board-mx53_smd.c
> > index 7970f7a..06070c5 100644
> > --- a/arch/arm/mach-mx5/board-mx53_smd.c
> > +++ b/arch/arm/mach-mx5/board-mx53_smd.c
> > @@ -39,20 +39,20 @@
> >  #define SMD_FEC_PHY_RST		IMX_GPIO_NR(7, 6)
> >  
> >  static iomux_v3_cfg_t mx53_smd_pads[] = {
> > -	MX53_PAD_CSI0_D10__UART1_TXD,
> > -	MX53_PAD_CSI0_D11__UART1_RXD,
> > -	MX53_PAD_ATA_DIOW__UART1_TXD,
> > -	MX53_PAD_ATA_DMACK__UART1_RXD,
> > -
> > -	MX53_PAD_ATA_BUFFER_EN__UART2_RXD,
> > -	MX53_PAD_ATA_DMARQ__UART2_TXD,
> > -	MX53_PAD_ATA_DIOR__UART2_RTS,
> > -	MX53_PAD_ATA_INTRQ__UART2_CTS,
> > -
> > -	MX53_PAD_ATA_CS_0__UART3_TXD,
> > -	MX53_PAD_ATA_CS_1__UART3_RXD,
> > -	MX53_PAD_ATA_DA_1__UART3_CTS,
> > -	MX53_PAD_ATA_DA_2__UART3_RTS,
> > +	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
> > +	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
> > +	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
> > +	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
same as above.

Thanks
Richard
> > +
> > +	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
> > +	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
> > +	MX53_PAD_PATA_DIOR__UART2_RTS,
> > +	MX53_PAD_PATA_INTRQ__UART2_CTS,
> > +
> > +	MX53_PAD_PATA_CS_0__UART3_TXD_MUX,
> > +	MX53_PAD_PATA_CS_1__UART3_RXD_MUX,
> > +	MX53_PAD_PATA_DA_1__UART3_CTS,
> > +	MX53_PAD_PATA_DA_2__UART3_RTS,
> >  };
> >  
> >  static const struct imxuart_platform_data mx53_smd_uart_data __initconst = {
> > -- 
> > 1.6.0.4
> > 
> > 
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd
  2011-01-27  9:30   ` Richard Zhao
@ 2011-01-27 11:48     ` Fabio Estevam
  2011-01-27 12:19       ` Richard Zhao
  0 siblings, 1 reply; 15+ messages in thread
From: Fabio Estevam @ 2011-01-27 11:48 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Richard,

On 1/27/2011 7:30 AM, Richard Zhao wrote:
....
>>>  static iomux_v3_cfg_t mx53_loco_pads[] = {
>>> -	MX53_PAD_CSI0_D10__UART1_TXD,
>>> -	MX53_PAD_CSI0_D11__UART1_RXD,
>>> -	MX53_PAD_ATA_DIOW__UART1_TXD,
>>> -	MX53_PAD_ATA_DMACK__UART1_RXD,
>>> -
>>> -	MX53_PAD_ATA_BUFFER_EN__UART2_RXD,
>>> -	MX53_PAD_ATA_DMARQ__UART2_TXD,
>>> -	MX53_PAD_ATA_DIOR__UART2_RTS,
>>> -	MX53_PAD_ATA_INTRQ__UART2_CTS,
>>> -
>>> -	MX53_PAD_ATA_CS_0__UART3_TXD,
>>> -	MX53_PAD_ATA_CS_1__UART3_RXD,
>>> -	MX53_PAD_ATA_DA_1__UART3_CTS,
>>> -	MX53_PAD_ATA_DA_2__UART3_RTS,
>>> +	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
>>> +	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
>>> +	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
>>> +	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
> So many Pad configured to uart1?

As per the subject the intention of this patch is to fix the build for mx53_loco and mx53_smd.

In this patch I just changed the pad names to fix the build issue. 


>>> +
>>> +	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
>>> +	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
>>> +	MX53_PAD_PATA_DIOR__UART2_RTS,
>>> +	MX53_PAD_PATA_INTRQ__UART2_CTS,
>>> +
>>> +	MX53_PAD_PATA_CS_0__UART3_TXD_MUX,
>>> +	MX53_PAD_PATA_CS_1__UART3_RXD_MUX,
>>> +	MX53_PAD_PATA_DA_1__UART3_CTS,
>>> +	MX53_PAD_PATA_DA_2__UART3_RTS,
> LoCo don't have uart2 and uart3.

Right, these are removed later in my patch series.

After my patch series is applied we have a working UART1 console.

Can we apply them? 

Regards,

Fabio Estevam
>>> +
>>>  };
>>>  
>>>  static const struct imxuart_platform_data mx53_loco_uart_data __initconst = {
>>> diff --git a/arch/arm/mach-mx5/board-mx53_smd.c b/arch/arm/mach-mx5/board-mx53_smd.c
>>> index 7970f7a..06070c5 100644
>>> --- a/arch/arm/mach-mx5/board-mx53_smd.c
>>> +++ b/arch/arm/mach-mx5/board-mx53_smd.c
>>> @@ -39,20 +39,20 @@
>>>  #define SMD_FEC_PHY_RST		IMX_GPIO_NR(7, 6)
>>>  
>>>  static iomux_v3_cfg_t mx53_smd_pads[] = {
>>> -	MX53_PAD_CSI0_D10__UART1_TXD,
>>> -	MX53_PAD_CSI0_D11__UART1_RXD,
>>> -	MX53_PAD_ATA_DIOW__UART1_TXD,
>>> -	MX53_PAD_ATA_DMACK__UART1_RXD,
>>> -
>>> -	MX53_PAD_ATA_BUFFER_EN__UART2_RXD,
>>> -	MX53_PAD_ATA_DMARQ__UART2_TXD,
>>> -	MX53_PAD_ATA_DIOR__UART2_RTS,
>>> -	MX53_PAD_ATA_INTRQ__UART2_CTS,
>>> -
>>> -	MX53_PAD_ATA_CS_0__UART3_TXD,
>>> -	MX53_PAD_ATA_CS_1__UART3_RXD,
>>> -	MX53_PAD_ATA_DA_1__UART3_CTS,
>>> -	MX53_PAD_ATA_DA_2__UART3_RTS,
>>> +	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
>>> +	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
>>> +	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
>>> +	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
> same as above.
> 
> Thanks
> Richard
>>> +
>>> +	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
>>> +	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
>>> +	MX53_PAD_PATA_DIOR__UART2_RTS,
>>> +	MX53_PAD_PATA_INTRQ__UART2_CTS,
>>> +
>>> +	MX53_PAD_PATA_CS_0__UART3_TXD_MUX,
>>> +	MX53_PAD_PATA_CS_1__UART3_RXD_MUX,
>>> +	MX53_PAD_PATA_DA_1__UART3_CTS,
>>> +	MX53_PAD_PATA_DA_2__UART3_RTS,
>>>  };
>>>  
>>>  static const struct imxuart_platform_data mx53_smd_uart_data __initconst = {
>>> -- 
>>> 1.6.0.4
>>>
>>>
>>>
>>
>> -- 
>> Pengutronix e.K.                           |                             |
>> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
>> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
>> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd
  2011-01-27 11:48     ` Fabio Estevam
@ 2011-01-27 12:19       ` Richard Zhao
  2011-01-27 12:58         ` "Porting the Linux Kernel to a New ARM Platform", updated...? Nick Pelling
  2011-01-28 12:26         ` [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd Fabio Estevam
  0 siblings, 2 replies; 15+ messages in thread
From: Richard Zhao @ 2011-01-27 12:19 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Jan 27, 2011 at 09:48:50AM -0200, Fabio Estevam wrote:
> Hi Richard,
> 
> On 1/27/2011 7:30 AM, Richard Zhao wrote:
> ....
> >>>  static iomux_v3_cfg_t mx53_loco_pads[] = {
> >>> -	MX53_PAD_CSI0_D10__UART1_TXD,
> >>> -	MX53_PAD_CSI0_D11__UART1_RXD,
> >>> -	MX53_PAD_ATA_DIOW__UART1_TXD,
> >>> -	MX53_PAD_ATA_DMACK__UART1_RXD,
> >>> -
> >>> -	MX53_PAD_ATA_BUFFER_EN__UART2_RXD,
> >>> -	MX53_PAD_ATA_DMARQ__UART2_TXD,
> >>> -	MX53_PAD_ATA_DIOR__UART2_RTS,
> >>> -	MX53_PAD_ATA_INTRQ__UART2_CTS,
> >>> -
> >>> -	MX53_PAD_ATA_CS_0__UART3_TXD,
> >>> -	MX53_PAD_ATA_CS_1__UART3_RXD,
> >>> -	MX53_PAD_ATA_DA_1__UART3_CTS,
> >>> -	MX53_PAD_ATA_DA_2__UART3_RTS,
> >>> +	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
> >>> +	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
> >>> +	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
> >>> +	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
> > So many Pad configured to uart1?
> 
> As per the subject the intention of this patch is to fix the build for mx53_loco and mx53_smd.
> 
> In this patch I just changed the pad names to fix the build issue. 
> 
> 
> >>> +
> >>> +	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
> >>> +	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
> >>> +	MX53_PAD_PATA_DIOR__UART2_RTS,
> >>> +	MX53_PAD_PATA_INTRQ__UART2_CTS,
> >>> +
> >>> +	MX53_PAD_PATA_CS_0__UART3_TXD_MUX,
> >>> +	MX53_PAD_PATA_CS_1__UART3_RXD_MUX,
> >>> +	MX53_PAD_PATA_DA_1__UART3_CTS,
> >>> +	MX53_PAD_PATA_DA_2__UART3_RTS,
> > LoCo don't have uart2 and uart3.
> 
> Right, these are removed later in my patch series.
I didn't see your patch series in my freescale mailbox, until Sascha replied. 
> 
> After my patch series is applied we have a working UART1 console.
> 
> Can we apply them? 
Sure. My two coins, why don't you squash patch 2 and 3. They're both small and
modifying the same thing. It don't matter much. If you choose to send it again,
you can merge my second patch.
> 
> Regards,
> 
> Fabio Estevam
> >>> +
> >>>  };
> >>>  
> >>>  static const struct imxuart_platform_data mx53_loco_uart_data __initconst = {
> >>> diff --git a/arch/arm/mach-mx5/board-mx53_smd.c b/arch/arm/mach-mx5/board-mx53_smd.c
> >>> index 7970f7a..06070c5 100644
> >>> --- a/arch/arm/mach-mx5/board-mx53_smd.c
> >>> +++ b/arch/arm/mach-mx5/board-mx53_smd.c
> >>> @@ -39,20 +39,20 @@
> >>>  #define SMD_FEC_PHY_RST		IMX_GPIO_NR(7, 6)
> >>>  
> >>>  static iomux_v3_cfg_t mx53_smd_pads[] = {
> >>> -	MX53_PAD_CSI0_D10__UART1_TXD,
> >>> -	MX53_PAD_CSI0_D11__UART1_RXD,
> >>> -	MX53_PAD_ATA_DIOW__UART1_TXD,
> >>> -	MX53_PAD_ATA_DMACK__UART1_RXD,
> >>> -
> >>> -	MX53_PAD_ATA_BUFFER_EN__UART2_RXD,
> >>> -	MX53_PAD_ATA_DMARQ__UART2_TXD,
> >>> -	MX53_PAD_ATA_DIOR__UART2_RTS,
> >>> -	MX53_PAD_ATA_INTRQ__UART2_CTS,
> >>> -
> >>> -	MX53_PAD_ATA_CS_0__UART3_TXD,
> >>> -	MX53_PAD_ATA_CS_1__UART3_RXD,
> >>> -	MX53_PAD_ATA_DA_1__UART3_CTS,
> >>> -	MX53_PAD_ATA_DA_2__UART3_RTS,
> >>> +	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
> >>> +	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
> >>> +	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
> >>> +	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
> > same as above.
will you fix iomux issue here? I didn't see any other fix in your patch series.

Thanks
Richard
> > 
> > Thanks
> > Richard
> >>> +
> >>> +	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
> >>> +	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
> >>> +	MX53_PAD_PATA_DIOR__UART2_RTS,
> >>> +	MX53_PAD_PATA_INTRQ__UART2_CTS,
> >>> +
> >>> +	MX53_PAD_PATA_CS_0__UART3_TXD_MUX,
> >>> +	MX53_PAD_PATA_CS_1__UART3_RXD_MUX,
> >>> +	MX53_PAD_PATA_DA_1__UART3_CTS,
> >>> +	MX53_PAD_PATA_DA_2__UART3_RTS,
> >>>  };
> >>>  
> >>>  static const struct imxuart_platform_data mx53_smd_uart_data __initconst = {
> >>> -- 
> >>> 1.6.0.4
> >>>
> >>>
> >>>
> >>
> >> -- 
> >> Pengutronix e.K.                           |                             |
> >> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> >> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> >> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> >>
> >> _______________________________________________
> >> linux-arm-kernel mailing list
> >> linux-arm-kernel at lists.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >>
> 
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* "Porting the Linux Kernel to a New ARM Platform", updated...?
  2011-01-27 12:19       ` Richard Zhao
@ 2011-01-27 12:58         ` Nick Pelling
  2011-02-03 14:31           ` Steve Chen
  2011-01-28 12:26         ` [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd Fabio Estevam
  1 sibling, 1 reply; 15+ messages in thread
From: Nick Pelling @ 2011-01-27 12:58 UTC (permalink / raw)
  To: linux-arm-kernel

Hi everyone,

I've been looking for a good source of information on getting Linux 
working on a new ARM target, including a checklist of things to cover 
such as putc(), arch_decomp_setup(), etc. So far, pretty much the 
best source of information I've found is Wookey & Tak-Shing's 
"Porting the Linux Kernel to a New ARM Platform"...
	http://www.glomationinc.com/PortingLinuxKernel.pdf
...but I can't help but notice that this is from 2002.

Is there an updated version of this document (or perhaps a book 
chapter covering this) you would recommend?

Cheers, ....Nick Pelling....

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd
  2011-01-27 12:19       ` Richard Zhao
  2011-01-27 12:58         ` "Porting the Linux Kernel to a New ARM Platform", updated...? Nick Pelling
@ 2011-01-28 12:26         ` Fabio Estevam
  1 sibling, 0 replies; 15+ messages in thread
From: Fabio Estevam @ 2011-01-28 12:26 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Richard,

On Thu, Jan 27, 2011 at 10:19 AM, Richard Zhao <linuxzsc@gmail.com> wrote:
....

>> Right, these are removed later in my patch series.
> I didn't see your patch series in my freescale mailbox, until Sascha replied.
>>
>> After my patch series is applied we have a working UART1 console.
>>
>> Can we apply them?
> Sure. My two coins, why don't you squash patch 2 and 3. They're both small and
> modifying the same thing. It don't matter much. If you choose to send it again,
> you can merge my second patch.

I preferred to split the patch as I did originally:

1/3: Fix the build issue on MX53_LOCO and MX53_SMD
2/3: Make UART1 functional on MX53_LOCO
3/3: Remove UART2 and UART3.
(http://www.spinics.net/lists/arm-kernel/msg112234.html  )

You can then send a patch for adding the additional peripherals of
MX53_LOCO board after these patch series are merged.

Does it sound good for you?
....
> will you fix iomux issue here? I didn't see any other fix in your patch series.

UART1 IOMUX is fixed in patch 2/3.

Regards,

Fabio Estevam

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd
  2011-01-25 15:08 [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd Fabio Estevam
  2011-01-25 15:08 ` [PATCH 2/3] ARM: mach-mx5/board-mx53_loco: Make UART1 functional Fabio Estevam
  2011-01-27  7:30 ` [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd Sascha Hauer
@ 2011-01-28 12:46 ` Richard Zhao
  2 siblings, 0 replies; 15+ messages in thread
From: Richard Zhao @ 2011-01-28 12:46 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jan 25, 2011 at 01:08:33PM -0200, Fabio Estevam wrote:
> Commit 816ad74 (ARM: i.MX53: Add full iomux support for mx53) renamed some of the pad names.
> 
> Make the changes accordingly so that mx53_loco and mx53_cmd can build without errors.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Richard Zhao <richard.zhao@freescale.com>
> ---
>  arch/arm/mach-mx5/board-mx53_loco.c |   25 +++++++++++++------------
>  arch/arm/mach-mx5/board-mx53_smd.c  |   24 ++++++++++++------------
>  2 files changed, 25 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c
> index d1348e0..dadc856 100644
> --- a/arch/arm/mach-mx5/board-mx53_loco.c
> +++ b/arch/arm/mach-mx5/board-mx53_loco.c
> @@ -39,20 +39,21 @@
>  #define LOCO_FEC_PHY_RST		IMX_GPIO_NR(7, 6)
>  
>  static iomux_v3_cfg_t mx53_loco_pads[] = {
> -	MX53_PAD_CSI0_D10__UART1_TXD,
> -	MX53_PAD_CSI0_D11__UART1_RXD,
> -	MX53_PAD_ATA_DIOW__UART1_TXD,
> -	MX53_PAD_ATA_DMACK__UART1_RXD,
> -
> -	MX53_PAD_ATA_BUFFER_EN__UART2_RXD,
> -	MX53_PAD_ATA_DMARQ__UART2_TXD,
> -	MX53_PAD_ATA_DIOR__UART2_RTS,
> -	MX53_PAD_ATA_INTRQ__UART2_CTS,
> -
> -	MX53_PAD_ATA_CS_0__UART3_TXD,
> -	MX53_PAD_ATA_CS_1__UART3_RXD,
> -	MX53_PAD_ATA_DA_1__UART3_CTS,
> -	MX53_PAD_ATA_DA_2__UART3_RTS,
> +	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
> +	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
> +	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
> +	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
> +
> +	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
> +	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
> +	MX53_PAD_PATA_DIOR__UART2_RTS,
> +	MX53_PAD_PATA_INTRQ__UART2_CTS,
> +
> +	MX53_PAD_PATA_CS_0__UART3_TXD_MUX,
> +	MX53_PAD_PATA_CS_1__UART3_RXD_MUX,
> +	MX53_PAD_PATA_DA_1__UART3_CTS,
> +	MX53_PAD_PATA_DA_2__UART3_RTS,
> +
>  };
>  
>  static const struct imxuart_platform_data mx53_loco_uart_data __initconst = {
> diff --git a/arch/arm/mach-mx5/board-mx53_smd.c b/arch/arm/mach-mx5/board-mx53_smd.c
> index 7970f7a..06070c5 100644
> --- a/arch/arm/mach-mx5/board-mx53_smd.c
> +++ b/arch/arm/mach-mx5/board-mx53_smd.c
> @@ -39,20 +39,20 @@
>  #define SMD_FEC_PHY_RST		IMX_GPIO_NR(7, 6)
>  
>  static iomux_v3_cfg_t mx53_smd_pads[] = {
> -	MX53_PAD_CSI0_D10__UART1_TXD,
> -	MX53_PAD_CSI0_D11__UART1_RXD,
> -	MX53_PAD_ATA_DIOW__UART1_TXD,
> -	MX53_PAD_ATA_DMACK__UART1_RXD,
> -
> -	MX53_PAD_ATA_BUFFER_EN__UART2_RXD,
> -	MX53_PAD_ATA_DMARQ__UART2_TXD,
> -	MX53_PAD_ATA_DIOR__UART2_RTS,
> -	MX53_PAD_ATA_INTRQ__UART2_CTS,
> -
> -	MX53_PAD_ATA_CS_0__UART3_TXD,
> -	MX53_PAD_ATA_CS_1__UART3_RXD,
> -	MX53_PAD_ATA_DA_1__UART3_CTS,
> -	MX53_PAD_ATA_DA_2__UART3_RTS,
> +	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
> +	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
> +	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
> +	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
> +
> +	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
> +	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
> +	MX53_PAD_PATA_DIOR__UART2_RTS,
> +	MX53_PAD_PATA_INTRQ__UART2_CTS,
> +
> +	MX53_PAD_PATA_CS_0__UART3_TXD_MUX,
> +	MX53_PAD_PATA_CS_1__UART3_RXD_MUX,
> +	MX53_PAD_PATA_DA_1__UART3_CTS,
> +	MX53_PAD_PATA_DA_2__UART3_RTS,
>  };
>  
>  static const struct imxuart_platform_data mx53_smd_uart_data __initconst = {
> -- 
> 1.6.0.4
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 2/3] ARM: mach-mx5/board-mx53_loco: Make UART1 functional
  2011-01-25 15:08 ` [PATCH 2/3] ARM: mach-mx5/board-mx53_loco: Make UART1 functional Fabio Estevam
  2011-01-25 15:08   ` [PATCH 3/3] ARM: mach-mx5/board-mx53_loco: Remove unused UARTs Fabio Estevam
@ 2011-01-28 12:48   ` Richard Zhao
  1 sibling, 0 replies; 15+ messages in thread
From: Richard Zhao @ 2011-01-28 12:48 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jan 25, 2011 at 01:08:34PM -0200, Fabio Estevam wrote:
> Fix IOMUX settings for UART1 and make UART1 functional.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Richard Zhao <richard.zhao@freescale.com>
> ---
>  arch/arm/mach-mx5/board-mx53_loco.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c
> index dadc856..cba4cd5 100644
> --- a/arch/arm/mach-mx5/board-mx53_loco.c
> +++ b/arch/arm/mach-mx5/board-mx53_loco.c
> @@ -41,8 +41,6 @@
>  static iomux_v3_cfg_t mx53_loco_pads[] = {
>  	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
>  	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
> -	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
> -	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
>  
>  	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
>  	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
> @@ -62,7 +60,7 @@ static const struct imxuart_platform_data mx53_loco_uart_data __initconst = {
>  
>  static inline void mx53_loco_init_uart(void)
>  {
> -	imx53_add_imx_uart(0, &mx53_loco_uart_data);
> +	imx53_add_imx_uart(0, NULL);
>  	imx53_add_imx_uart(1, &mx53_loco_uart_data);
>  	imx53_add_imx_uart(2, &mx53_loco_uart_data);
>  }
> -- 
> 1.6.0.4
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 3/3] ARM: mach-mx5/board-mx53_loco: Remove unused UARTs
  2011-01-25 15:08   ` [PATCH 3/3] ARM: mach-mx5/board-mx53_loco: Remove unused UARTs Fabio Estevam
@ 2011-01-28 12:48     ` Richard Zhao
  0 siblings, 0 replies; 15+ messages in thread
From: Richard Zhao @ 2011-01-28 12:48 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jan 25, 2011 at 01:08:35PM -0200, Fabio Estevam wrote:
> On mx53_loco only UART1 is used and its signals go to connector J16.
> 
> Remove UART2 and UART3 as they are not used on this board.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Richard Zhao <richard.zhao@freescale.com>
> ---
>  arch/arm/mach-mx5/board-mx53_loco.c |   24 +-----------------------
>  1 files changed, 1 insertions(+), 23 deletions(-)
> 
> diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c
> index cba4cd5..3aefd6d 100644
> --- a/arch/arm/mach-mx5/board-mx53_loco.c
> +++ b/arch/arm/mach-mx5/board-mx53_loco.c
> @@ -41,30 +41,8 @@
>  static iomux_v3_cfg_t mx53_loco_pads[] = {
>  	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
>  	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
> -
> -	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
> -	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
> -	MX53_PAD_PATA_DIOR__UART2_RTS,
> -	MX53_PAD_PATA_INTRQ__UART2_CTS,
> -
> -	MX53_PAD_PATA_CS_0__UART3_TXD_MUX,
> -	MX53_PAD_PATA_CS_1__UART3_RXD_MUX,
> -	MX53_PAD_PATA_DA_1__UART3_CTS,
> -	MX53_PAD_PATA_DA_2__UART3_RTS,
> -
> -};
> -
> -static const struct imxuart_platform_data mx53_loco_uart_data __initconst = {
> -	.flags = IMXUART_HAVE_RTSCTS,
>  };
>  
> -static inline void mx53_loco_init_uart(void)
> -{
> -	imx53_add_imx_uart(0, NULL);
> -	imx53_add_imx_uart(1, &mx53_loco_uart_data);
> -	imx53_add_imx_uart(2, &mx53_loco_uart_data);
> -}
> -
>  static inline void mx53_loco_fec_reset(void)
>  {
>  	int ret;
> @@ -88,7 +66,7 @@ static void __init mx53_loco_board_init(void)
>  {
>  	mxc_iomux_v3_setup_multiple_pads(mx53_loco_pads,
>  					ARRAY_SIZE(mx53_loco_pads));
> -	mx53_loco_init_uart();
> +	imx53_add_imx_uart(0, NULL);
>  	mx53_loco_fec_reset();
>  	imx53_add_fec(&mx53_loco_fec_data);
>  }
> -- 
> 1.6.0.4
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* "Porting the Linux Kernel to a New ARM Platform", updated...?
  2011-01-27 12:58         ` "Porting the Linux Kernel to a New ARM Platform", updated...? Nick Pelling
@ 2011-02-03 14:31           ` Steve Chen
  2011-02-03 14:36             ` Russell King - ARM Linux
       [not found]             ` <AANLkTikWsU2V+1ohAaiFfRneLjsGRWx7ee5X655mAa18@mail.gmail.c om>
  0 siblings, 2 replies; 15+ messages in thread
From: Steve Chen @ 2011-02-03 14:31 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Jan 27, 2011 at 6:58 AM, Nick Pelling <nickpelling@nanodome.com> wrote:
> Hi everyone,
>
> I've been looking for a good source of information on getting Linux working
> on a new ARM target, including a checklist of things to cover such as
> putc(), arch_decomp_setup(), etc. So far, pretty much the best source of
> information I've found is Wookey & Tak-Shing's "Porting the Linux Kernel to
> a New ARM Platform"...
> ? ? ? ?http://www.glomationinc.com/PortingLinuxKernel.pdf
> ...but I can't help but notice that this is from 2002.
>
> Is there an updated version of this document (or perhaps a book chapter
> covering this) you would recommend?
>
> Cheers, ....Nick Pelling....

Hello,

I took a quick look at the document.  Much of the information still
applies to the latest kernel.  The biggest change that I can see is
that the directories were moved and files renames.  For example

arch/arm/deconfigs/ is now arch/arm/configs
config.in is now Kconfig
include/asm-arm/arch-xxx is moved to arch/arm/mach-xxx/include

By the way, include/asm is a symlink points to
include/asm-arm/arch-xxxx in the older kernels.  The link is created
by the make.  If I were to get Linux to boot on a new board, I would
start by looking at code for a similar target with the same SoC.

I hope that helps.

Steve

^ permalink raw reply	[flat|nested] 15+ messages in thread

* "Porting the Linux Kernel to a New ARM Platform", updated...?
  2011-02-03 14:31           ` Steve Chen
@ 2011-02-03 14:36             ` Russell King - ARM Linux
       [not found]             ` <AANLkTikWsU2V+1ohAaiFfRneLjsGRWx7ee5X655mAa18@mail.gmail.c om>
  1 sibling, 0 replies; 15+ messages in thread
From: Russell King - ARM Linux @ 2011-02-03 14:36 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Feb 03, 2011 at 08:31:04AM -0600, Steve Chen wrote:
> By the way, include/asm is a symlink points to
> include/asm-arm/arch-xxxx in the older kernels.

In old kernels, include/asm was pointed at include/asm-arm.  We had a
second symlink for include/asm-arm/arch which pointed at
include/asm-arm/arch-xxx.  Even older kernels had another symlink for
include/asm-arm/proc pointing at either include/asm-arm/proc-armv or
.../proc-armo depending on whether we were building for 32-bit or 26-bit
ARMs.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* "Porting the Linux Kernel to a New ARM Platform", updated...?
       [not found]             ` <AANLkTikWsU2V+1ohAaiFfRneLjsGRWx7ee5X655mAa18@mail.gmail.c om>
@ 2011-02-05  9:59               ` Nick Pelling
  0 siblings, 0 replies; 15+ messages in thread
From: Nick Pelling @ 2011-02-05  9:59 UTC (permalink / raw)
  To: linux-arm-kernel

Hi everyone,

At 08:31 03/02/2011 -0600, Steve Chen wrote:
>I took a quick look at the document.  Much of the information still
>applies to the latest kernel.  The biggest change that I can see is
>that the directories were moved and files renames.  For example
>
>arch/arm/deconfigs/ is now arch/arm/configs
>config.in is now Kconfig
>include/asm-arm/arch-xxx is moved to arch/arm/mach-xxx/include
>
>By the way, include/asm is a symlink points to
>include/asm-arm/arch-xxxx in the older kernels.  The link is created
>by the make.  If I were to get Linux to boot on a new board, I would
>start by looking at code for a similar target with the same SoC.

Thanks, Steve, very helpful. I also got an off-list message from 
Wookey, who said of his document that...

"more recent docs have been written superseding much of what is in 
there (e.g Vince Sanders' booting the kernel doc: 
http://www.simtec.co.uk/products/SWLINUX/files/booting_article.html#
but which is about to be finally outdated by devicetree possibilities)"

He also suggested http://free-electrons.com/doc/kernel-porting.pdf as 
likely to be useful.

Cheers, ....Nick Pelling.... 

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2011-02-05  9:59 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-25 15:08 [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd Fabio Estevam
2011-01-25 15:08 ` [PATCH 2/3] ARM: mach-mx5/board-mx53_loco: Make UART1 functional Fabio Estevam
2011-01-25 15:08   ` [PATCH 3/3] ARM: mach-mx5/board-mx53_loco: Remove unused UARTs Fabio Estevam
2011-01-28 12:48     ` Richard Zhao
2011-01-28 12:48   ` [PATCH 2/3] ARM: mach-mx5/board-mx53_loco: Make UART1 functional Richard Zhao
2011-01-27  7:30 ` [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd Sascha Hauer
2011-01-27  9:30   ` Richard Zhao
2011-01-27 11:48     ` Fabio Estevam
2011-01-27 12:19       ` Richard Zhao
2011-01-27 12:58         ` "Porting the Linux Kernel to a New ARM Platform", updated...? Nick Pelling
2011-02-03 14:31           ` Steve Chen
2011-02-03 14:36             ` Russell King - ARM Linux
     [not found]             ` <AANLkTikWsU2V+1ohAaiFfRneLjsGRWx7ee5X655mAa18@mail.gmail.c om>
2011-02-05  9:59               ` Nick Pelling
2011-01-28 12:26         ` [PATCH 1/3] ARM: mach-mx5: Fix build for mx53_loco and mx53_smd Fabio Estevam
2011-01-28 12:46 ` Richard Zhao

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.