All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Greg KH <gregkh@suse.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH 1/3] tty: move hvc drivers to drivers/tty/hvc/
Date: Fri, 28 Jan 2011 11:29:04 +0530	[thread overview]
Message-ID: <20110128055904.GA9218@amit-x200.redhat.com> (raw)
In-Reply-To: <20110128042125.GA1844@suse.de>

On (Thu) Jan 27 2011 [20:21:25], Greg KH wrote:
> > > Sorry about this, the idea to move this file was mine and my original
> > > patch did this as well. I remembered the code from when it was a simple
> > > console driver based on hvc and never noticed that it had evolved into
> > > a generic host/guest communication stack.
> > > 
> > > > Can you please move it back?
> > > 
> > > No objection from me here in general, though as Greg writes above, it's
> > > a bit ugly when hvc_console.h is in a different directory.
> > 
> > Greg, can you do this please?  (A way to do it with preservig git
> > history of the file would be great as well, but I think only a revert
> > will do that?)
> 
> So just move the one file, virtio_console.c?  If so, yes, I can move it
> back.

Yes, just the one file.

> > > > I could perhaps think of a way of splitting the file so the hvc bits can
> > > > be moved to drivers/tty/hvc/ and having the core stay in drivers/char/,
> > > > but that'll have to wait for the next cycle.
> 
> That would be great, care to send me those patches now so I can queue it
> up for .39?

It was just a thought; I don't have patches yet.  I'll send them your
way once they're ready.

Thanks,
		Amit

  reply	other threads:[~2011-01-28  5:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20 17:49 [GIT PATCH] TTY/serial driver movement for .38 Greg KH
2011-01-20 18:03 ` [PATCH 1/3] tty: move hvc drivers to drivers/tty/hvc/ Greg Kroah-Hartman
2011-01-20 18:27   ` Arnd Bergmann
2011-01-27 18:29   ` Amit Shah
2011-01-27 21:53     ` Arnd Bergmann
2011-01-28  2:57       ` Amit Shah
2011-01-28  4:21         ` Greg KH
2011-01-28  5:59           ` Amit Shah [this message]
2011-01-28 15:20             ` Greg KH
2011-01-31 22:14             ` Greg KH
2011-02-01  3:27               ` Amit Shah
2011-02-01  4:01               ` [PATCH] virtio: console: Move file back to drivers/char/ Amit Shah
2011-02-01 12:40                 ` Arnd Bergmann
2011-02-01 12:40                 ` Arnd Bergmann
2011-02-01  4:01               ` Amit Shah
2011-01-20 18:03 ` [PATCH 2/3] tty: move drivers/serial/ to drivers/tty/serial/ Greg Kroah-Hartman
2011-01-20 18:27   ` Arnd Bergmann
2011-01-20 18:03 ` [PATCH 3/3] tty: update MAINTAINERS file due to driver movement Greg Kroah-Hartman
2011-01-20 18:32 ` [GIT PATCH] TTY/serial driver movement for .38 Arnd Bergmann
2011-01-20 18:48   ` Greg KH
2011-01-20 19:45   ` Alan Cox
2011-01-20 20:23     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110128055904.GA9218@amit-x200.redhat.com \
    --to=amit.shah@redhat.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.