From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Fri, 28 Jan 2011 13:13:59 -0600
Subject: [U-Boot] [PATCH 5/8 v3] P1021: add P1021MDS board support
In-Reply-To: <AANLkTin2dxhLWWDX4CLPM=SP3SpjxecC==Zx4KowMrSx@mail.gmail.com>
References: <1296190690-21146-1-git-send-email-Haiying.Wang@freescale.com>
	<1296190690-21146-3-git-send-email-Haiying.Wang@freescale.com>
	<AANLkTin2dxhLWWDX4CLPM=SP3SpjxecC==Zx4KowMrSx@mail.gmail.com>
Message-ID: <20110128131359.77bbfb1a@udp111988uds.am.freescale.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, 28 Jan 2011 13:06:28 -0600
Timur Tabi <timur@freescale.com> wrote:

> > +void putc(char c)
> > +{
> > + ? ? ? if (c == '\n')
> > + ? ? ? ? ? ? ? NS16550_putc((NS16550_t)CONFIG_SYS_NS16550_COM1, '\r');
> > +
> > + ? ? ? NS16550_putc((NS16550_t)CONFIG_SYS_NS16550_COM1, c);
> > +}
> > +
> > +void puts(const char *str)
> > +{
> > + ? ? ? while (*str)
> > + ? ? ? ? ? ? ? putc(*str++);
> > +}
> 
> These look like functions that shouldn't be in board-specific code.

That's been established practice in the SPL board files so far, though
I suppose it could be factored out to its own file.

-Scott