All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serge@hallyn.com>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: Soren Hansen <soren@linux2go.dk>,
	linux-kernel@vger.kernel.org, Dave Hansen <haveblue@us.ibm.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: nbd locking problems
Date: Mon, 31 Jan 2011 19:35:07 +0000	[thread overview]
Message-ID: <20110131193507.GA19778@mail.hallyn.com> (raw)
In-Reply-To: <20110128211825.GA20707@mail.hallyn.com>

Quoting Serge E. Hallyn (serge@hallyn.com):
> Quoting Soren Hansen (soren@linux2go.dk):

(Sorry, I seem to have stupidly deleted later replies)

> 
> As Dave just explained to me, BKL is released when you sleep :)  I
> assume that's how it gets released around the kthread_create().  I
> *think* you're right that the new mutex is superfluous, but I'd like to
> look through the ioctl code and make sure there's no shared state which
> we need to protect.  I don't see how there could be, or rather, if there
> were, then it was broken before.

Yup, removing nbd_mutex should be safe.  Esp since the
bdev->bd_disk->private_data doesn't get changed outside
of nbd_init().  Removing it looks safe.

thanks,
-serge

  parent reply	other threads:[~2011-01-31 19:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26 10:52 nbd locking problems Soren Hansen
2011-01-28 21:18 ` Serge E. Hallyn
2011-01-28 21:30   ` Arnd Bergmann
2011-01-28 23:11   ` Soren Hansen
2011-03-13 10:28     ` Pavel Machek
2011-01-31 19:35   ` Serge E. Hallyn [this message]
2011-01-28 23:23 ` [PATCH] nbd: Remove module-level ioctl mutex Soren Hansen
2011-01-30 15:07 nbd locking problems Paul Clements

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110131193507.GA19778@mail.hallyn.com \
    --to=serge@hallyn.com \
    --cc=arnd@arndb.de \
    --cc=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=soren@linux2go.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.