From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= Subject: Re: [PATCH v2 16/16] skge: convert to hw_features Date: Mon, 31 Jan 2011 23:40:32 +0100 Message-ID: <20110131224032.GA23032@rere.qmqm.pl> References: <34b51af1d2b880439d2d210837fc87a89c0b9ec4.1295734271.git.mirq-linux@rere.qmqm.pl> <20110131084502.7be146e7@nehalam> <20110131215343.GA19379@rere.qmqm.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev@vger.kernel.org, Ben Hutchings To: Stephen Hemminger Return-path: Received: from rere.qmqm.pl ([89.167.52.164]:49480 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754113Ab1AaWkd (ORCPT ); Mon, 31 Jan 2011 17:40:33 -0500 Content-Disposition: inline In-Reply-To: <20110131215343.GA19379@rere.qmqm.pl> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jan 31, 2011 at 10:53:43PM +0100, Micha=B3 Miros=B3aw wrote: > On Mon, Jan 31, 2011 at 08:45:02AM -0800, Stephen Hemminger wrote: > > On Sat, 22 Jan 2011 23:14:14 +0100 (CET) > > Micha=B3 Miros=B3aw wrote: > > > The hardware might do full HW_CSUM, not just IP_CSUM, but it's no= t tested > > > and so not changed here. > > > Signed-off-by: Micha=B3 Miros=B3aw > > The skge hardware does not do full HW_CSUM. It looks at the IP head= er. > Driver code suggests otherwise. Please look at skge_xmit_frame() and = TX > descriptor format. >=20 > Besides, I'm locally using a patch that makes skge advertise HW_CSUM = - TCP > over IPv6 is correctly checksummed in hardware (haven't tried VLANs y= et). IPv4 UDP inside VLAN-tagged packet is also checksummed properly by hard= ware. I don't have time now to make a proper HW_CSUM test (with arbitrary hea= der prepended). If someone has one (or patches?), I'd be glad to use it, th= ough. Best Regards, Micha=B3 Miros=B3aw