All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Len Brown <lenb@kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Luming Yu <luming.yu@intel.com>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	linux-acpi@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: [PATCH] gpu/stub: fix acpi_video build error, fix stub kconfig dependencies
Date: Tue, 1 Feb 2011 11:17:28 -0800	[thread overview]
Message-ID: <20110201111728.cb786487.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20110201120323.GA6714@elte.hu>

From: Randy Dunlap <randy.dunlap@oracle.com>

The comments under "config STUB_POULSBO" are close to correct,
but they are not being followed.  This patch updates them to reflect
the requirements for THERMAL.

This build error is caused by STUB_POULSBO selecting ACPI_VIDEO
when ACPI_VIDEO's config requirements are not met.

ERROR: "thermal_cooling_device_register" [drivers/acpi/video.ko] undefined!
ERROR: "thermal_cooling_device_unregister" [drivers/acpi/video.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/gpu/stub/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

--- lnx-2638-rc3.orig/drivers/gpu/stub/Kconfig
+++ lnx-2638-rc3/drivers/gpu/stub/Kconfig
@@ -1,11 +1,13 @@
 config STUB_POULSBO
 	tristate "Intel GMA500 Stub Driver"
 	depends on PCI
+	depends on NET # for THERMAL
 	# Poulsbo stub depends on ACPI_VIDEO when ACPI is enabled
 	# but for select to work, need to select ACPI_VIDEO's dependencies, ick
 	select BACKLIGHT_CLASS_DEVICE if ACPI
 	select INPUT if ACPI
 	select ACPI_VIDEO if ACPI
+	select THERMAL if ACPI
 	help
 	  Choose this option if you have a system that has Intel GMA500
 	  (Poulsbo) integrated graphics. If M is selected, the module will

  reply	other threads:[~2011-02-01 19:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20  9:00 linux-next: Tree for December 20 Stephen Rothwell
2010-12-20 16:14 ` Zimny Lech
2010-12-20 20:49   ` Stephen Rothwell
2010-12-20 16:53 ` linux-next: Tree for December 20 (acpi_video) Randy Dunlap
2011-01-26 11:42   ` Ingo Molnar
2011-02-01 12:03     ` [upstream build breakage] " Ingo Molnar
2011-02-01 19:17       ` Randy Dunlap [this message]
2011-02-02  1:35         ` [PATCH] gpu/stub: fix acpi_video build error, fix stub kconfig dependencies Ingo Molnar
2011-02-28 17:03       ` [PATCH upstream build breakage] acpi: several drivers depend on NET Randy Dunlap
2011-02-28 20:37         ` Rafael J. Wysocki
2011-02-28 22:42           ` Rafael J. Wysocki
2011-03-01  0:00             ` Randy Dunlap
2011-03-01  0:12               ` Rafael J. Wysocki
2011-03-01  6:17                 ` [build fix] ACPI: Fix build for CONFIG_NET unset Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110201111728.cb786487.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=luming.yu@intel.com \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.