From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 12/22] kvm: Call qemu_kvm_eat_signals also under
 !CONFIG_IOTHREAD
Date: Tue, 1 Feb 2011 10:49:10 -0200
Message-ID: <20110201124910.GB12061@amt.cnet>
References: <cover.1296133797.git.jan.kiszka@siemens.com>
 <0e59ec643d0d2abfb497091672daa9e8ae7f0353.1296133797.git.jan.kiszka@siemens.com>
 <20110201123835.GA12439@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org,
	qemu-devel@nongnu.org
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:26354 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751640Ab1BANPH (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 1 Feb 2011 08:15:07 -0500
Content-Disposition: inline
In-Reply-To: <20110201123835.GA12439@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Feb 01, 2011 at 10:38:35AM -0200, Marcelo Tosatti wrote:
> > @@ -943,7 +951,11 @@ bool cpu_exec_all(void)
> >          if (qemu_alarm_pending())
> >              break;
> >          if (cpu_can_run(env)) {
> > -            if (qemu_cpu_exec(env) == EXCP_DEBUG) {
> > +            r = qemu_cpu_exec(env);
> > +            if (kvm_enabled()) {
> > +                qemu_kvm_eat_signals(env);
> > +            }
> > +            if (r == EXCP_DEBUG) {
> >                  break;
> >              }
> 
> As mentioned before, signal processing should be independent of
> cpu_can_run (still want to process SIGALRM if vm is stopped, for
> example).

Nevermind that comment.

From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55633 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PkG4X-0007N2-RM
	for qemu-devel@nongnu.org; Tue, 01 Feb 2011 08:15:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1PkG4W-0006U8-Qh
	for qemu-devel@nongnu.org; Tue, 01 Feb 2011 08:15:05 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43031)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1PkG4W-0006Tv-Jh
	for qemu-devel@nongnu.org; Tue, 01 Feb 2011 08:15:04 -0500
Date: Tue, 1 Feb 2011 10:49:10 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20110201124910.GB12061@amt.cnet>
References: <cover.1296133797.git.jan.kiszka@siemens.com>
	<0e59ec643d0d2abfb497091672daa9e8ae7f0353.1296133797.git.jan.kiszka@siemens.com>
	<20110201123835.GA12439@amt.cnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110201123835.GA12439@amt.cnet>
Subject: [Qemu-devel] Re: [PATCH 12/22] kvm: Call qemu_kvm_eat_signals also
 under !CONFIG_IOTHREAD
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

On Tue, Feb 01, 2011 at 10:38:35AM -0200, Marcelo Tosatti wrote:
> > @@ -943,7 +951,11 @@ bool cpu_exec_all(void)
> >          if (qemu_alarm_pending())
> >              break;
> >          if (cpu_can_run(env)) {
> > -            if (qemu_cpu_exec(env) == EXCP_DEBUG) {
> > +            r = qemu_cpu_exec(env);
> > +            if (kvm_enabled()) {
> > +                qemu_kvm_eat_signals(env);
> > +            }
> > +            if (r == EXCP_DEBUG) {
> >                  break;
> >              }
> 
> As mentioned before, signal processing should be independent of
> cpu_can_run (still want to process SIGALRM if vm is stopped, for
> example).

Nevermind that comment.