All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Kwolek <adam.kwolek@intel.com>
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
	ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: [PATCH 3/8] imsm: FIX: Size is already set in metadata
Date: Tue, 01 Feb 2011 14:49:20 +0100	[thread overview]
Message-ID: <20110201134920.13398.77330.stgit@gklab-128-013.igk.intel.com> (raw)
In-Reply-To: <20110201134226.13398.4071.stgit@gklab-128-013.igk.intel.com>

In metadata size is set already during migration initialization.
There is no reason for second /the same/ calculation.

Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
---

 super-intel.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/super-intel.c b/super-intel.c
index 42f7065..62b13b0 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -5185,15 +5185,12 @@ static int imsm_set_array_state(struct active_array *a, int consistent)
 				/* round array size down to closest MB */
 				array_blocks = (array_blocks >> SECT_PER_MB_SHIFT)
 					<< SECT_PER_MB_SHIFT;
-				dev->size_low = __cpu_to_le32((__u32) array_blocks);
-				dev->size_high = __cpu_to_le32((__u32) (array_blocks >> 32));
 				a->info.custom_array_size = array_blocks/2;
 				a->check_reshape = 1; /* encourage manager to update
 						       * array size
 						       */
-				super->updates_pending++;
 				imsm_progress_container_reshape(super);
-			}				
+			}
 		}
 	}
 


  parent reply	other threads:[~2011-02-01 13:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01 13:48 [PATCH 0/8] Set of fixes for expansion Adam Kwolek
2011-02-01 13:49 ` [PATCH 1/8] FIX: Last checkpoint is not set Adam Kwolek
2011-02-01 13:49 ` [PATCH 2/8] imsm: FIX: array size is wrong Adam Kwolek
2011-02-03  6:41   ` NeilBrown
2011-02-03  9:56     ` Kwolek, Adam
2011-02-01 13:49 ` Adam Kwolek [this message]
2011-02-03  6:45   ` [PATCH 3/8] imsm: FIX: Size is already set in metadata NeilBrown
2011-02-03  9:52     ` Kwolek, Adam
2011-02-03 10:42       ` NeilBrown
2011-02-01 13:49 ` [PATCH 4/8] imsm: FIX: put expansion finalization in to one place Adam Kwolek
2011-02-01 13:49 ` [PATCH 5/8] imsm: fix: imsm_num_data_members() can return error Adam Kwolek
2011-02-01 13:49 ` [PATCH 6/8] FIX: Do not set array size after reshape in mdadm Adam Kwolek
2011-02-03  6:56   ` NeilBrown
2011-02-03 10:08     ` Kwolek, Adam
2011-02-03 10:44       ` NeilBrown
2011-02-01 13:49 ` [PATCH 7/8] imsm: FIX: Debug strings cleanup Adam Kwolek
2011-02-01 13:50 ` [PATCH 8/8] imsm: move common code for array size calculation to function Adam Kwolek
2011-02-03  7:22 ` [PATCH 0/8] Set of fixes for expansion NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110201134920.13398.77330.stgit@gklab-128-013.igk.intel.com \
    --to=adam.kwolek@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ed.ciechanowski@intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=wojciech.neubauer@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.