All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Ferenc Wagner <wferi@niif.hu>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: ucb1400_gpio driver Kconfig entry
Date: Tue, 1 Feb 2011 18:38:52 +0100	[thread overview]
Message-ID: <201102011838.52571.marek.vasut@gmail.com> (raw)
In-Reply-To: <87ipx3r7i7.fsf@tac.ki.iif.hu>

On Tuesday 01 February 2011 18:26:24 Ferenc Wagner wrote:
> Marek Vasut <marek.vasut@gmail.com> writes:
> > On Tuesday 01 February 2011 14:05:13 Ferenc Wagner wrote:
> >> drivers/gpio/Kconfig says:
> >> 
> >> config GPIO_UCB1400
> >> 
> >>         bool "Philips UCB1400 GPIO"
> >>         depends on UCB1400_CORE
> >>         help
> >>         
> >>           This enables support for the Philips UCB1400 GPIO pins.
> >>           The UCB1400 is an AC97 audio codec.
> >>           
> >>           To compile this driver as a module, choose M here: the
> >>           module will be called ucb1400_gpio.
> >> 
> >> But you use bool above, so choosing M isn't actually an option.
> >> Maybe you want to resolve this inconsistency.
> > 
> > I don't really have any device with ucb1400 available now. I will have
> > some probably sometimes soon though. On the other hand, if you know
> > it's a correct fix, you can send a patch.
> 
> This note hasn't got much to do with the driver code itself.  Either you
> want to enable compiling the driver as a module, then use tristate
> instead of bool; or it isn't an option and then remove the corresponding
> paragraph from the documentation.  The latter is improbable, and a
> quick look at the code seems to confirm that the driver was actually
> intended to be used as a module.  So I suggest replacing bool with
> tristate.  But I don't know anything at all about this driver or device.

I know what this thing is -- it's a MFD chip with audio/touchscreen/gpio on it. 
I'll get to a device with such thing soon, so don't worry. I'll keep this in 
ToDo. I think it should be possible to compile this as a module btw.

Cheers

      reply	other threads:[~2011-02-01 17:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01 13:05 ucb1400_gpio driver Kconfig entry Ferenc Wagner
2011-02-01 17:16 ` Marek Vasut
2011-02-01 17:26   ` Ferenc Wagner
2011-02-01 17:38     ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201102011838.52571.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wferi@niif.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.