* [PATCH] arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints
@ 2011-02-01 15:36 ` Aaro Koskinen
0 siblings, 0 replies; 8+ messages in thread
From: Aaro Koskinen @ 2011-02-01 15:36 UTC (permalink / raw)
To: tony, linux-omap, linux-arm-kernel; +Cc: Aaro Koskinen
With the commit 757902513019e6ee469791ff76f954b19ca8d036 fixed voltage
regulator setup will fail if there are voltage constraints defined. This
made MMC unusable on this board. Fix by just deleting those redundant
constraints.
Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
---
arch/arm/mach-omap2/board-rm680.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/board-rm680.c b/arch/arm/mach-omap2/board-rm680.c
index cb77be7..39a71bb 100644
--- a/arch/arm/mach-omap2/board-rm680.c
+++ b/arch/arm/mach-omap2/board-rm680.c
@@ -40,9 +40,6 @@ static struct regulator_consumer_supply rm680_vemmc_consumers[] = {
static struct regulator_init_data rm680_vemmc = {
.constraints = {
.name = "rm680_vemmc",
- .min_uV = 2900000,
- .max_uV = 2900000,
- .apply_uV = 1,
.valid_modes_mask = REGULATOR_MODE_NORMAL
| REGULATOR_MODE_STANDBY,
.valid_ops_mask = REGULATOR_CHANGE_STATUS
--
1.5.6.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints
@ 2011-02-01 15:36 ` Aaro Koskinen
0 siblings, 0 replies; 8+ messages in thread
From: Aaro Koskinen @ 2011-02-01 15:36 UTC (permalink / raw)
To: linux-arm-kernel
With the commit 757902513019e6ee469791ff76f954b19ca8d036 fixed voltage
regulator setup will fail if there are voltage constraints defined. This
made MMC unusable on this board. Fix by just deleting those redundant
constraints.
Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
---
arch/arm/mach-omap2/board-rm680.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/board-rm680.c b/arch/arm/mach-omap2/board-rm680.c
index cb77be7..39a71bb 100644
--- a/arch/arm/mach-omap2/board-rm680.c
+++ b/arch/arm/mach-omap2/board-rm680.c
@@ -40,9 +40,6 @@ static struct regulator_consumer_supply rm680_vemmc_consumers[] = {
static struct regulator_init_data rm680_vemmc = {
.constraints = {
.name = "rm680_vemmc",
- .min_uV = 2900000,
- .max_uV = 2900000,
- .apply_uV = 1,
.valid_modes_mask = REGULATOR_MODE_NORMAL
| REGULATOR_MODE_STANDBY,
.valid_ops_mask = REGULATOR_CHANGE_STATUS
--
1.5.6.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints
2011-02-01 15:36 ` Aaro Koskinen
@ 2011-02-01 18:27 ` Jarkko Nikula
-1 siblings, 0 replies; 8+ messages in thread
From: Jarkko Nikula @ 2011-02-01 18:27 UTC (permalink / raw)
To: Aaro Koskinen; +Cc: tony, linux-omap, linux-arm-kernel
On Tue, 1 Feb 2011 17:36:28 +0200
Aaro Koskinen <aaro.koskinen@nokia.com> wrote:
> With the commit 757902513019e6ee469791ff76f954b19ca8d036 fixed voltage
> regulator setup will fail if there are voltage constraints defined. This
> made MMC unusable on this board. Fix by just deleting those redundant
> constraints.
>
True. Before there were a test min_uV == max_uV && ops->set_voltage and
now min_uV == max_uV followed by test for ops->set_voltage that returns
EINVAL if not set (NULL for fixed voltage regulator obviously).
Reviewed-by: Jarkko Nikula <jhnikula@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints
@ 2011-02-01 18:27 ` Jarkko Nikula
0 siblings, 0 replies; 8+ messages in thread
From: Jarkko Nikula @ 2011-02-01 18:27 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 1 Feb 2011 17:36:28 +0200
Aaro Koskinen <aaro.koskinen@nokia.com> wrote:
> With the commit 757902513019e6ee469791ff76f954b19ca8d036 fixed voltage
> regulator setup will fail if there are voltage constraints defined. This
> made MMC unusable on this board. Fix by just deleting those redundant
> constraints.
>
True. Before there were a test min_uV == max_uV && ops->set_voltage and
now min_uV == max_uV followed by test for ops->set_voltage that returns
EINVAL if not set (NULL for fixed voltage regulator obviously).
Reviewed-by: Jarkko Nikula <jhnikula@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints
2011-02-01 18:27 ` Jarkko Nikula
@ 2011-02-01 23:52 ` Tony Lindgren
-1 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2011-02-01 23:52 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: Aaro Koskinen, linux-omap, linux-arm-kernel
* Jarkko Nikula <jhnikula@gmail.com> [110201 10:26]:
> On Tue, 1 Feb 2011 17:36:28 +0200
> Aaro Koskinen <aaro.koskinen@nokia.com> wrote:
>
> > With the commit 757902513019e6ee469791ff76f954b19ca8d036 fixed voltage
> > regulator setup will fail if there are voltage constraints defined. This
> > made MMC unusable on this board. Fix by just deleting those redundant
> > constraints.
> >
> True. Before there were a test min_uV == max_uV && ops->set_voltage and
> now min_uV == max_uV followed by test for ops->set_voltage that returns
> EINVAL if not set (NULL for fixed voltage regulator obviously).
>
> Reviewed-by: Jarkko Nikula <jhnikula@gmail.com>
Thanks adding into devel-fixes.
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints
@ 2011-02-01 23:52 ` Tony Lindgren
0 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2011-02-01 23:52 UTC (permalink / raw)
To: linux-arm-kernel
* Jarkko Nikula <jhnikula@gmail.com> [110201 10:26]:
> On Tue, 1 Feb 2011 17:36:28 +0200
> Aaro Koskinen <aaro.koskinen@nokia.com> wrote:
>
> > With the commit 757902513019e6ee469791ff76f954b19ca8d036 fixed voltage
> > regulator setup will fail if there are voltage constraints defined. This
> > made MMC unusable on this board. Fix by just deleting those redundant
> > constraints.
> >
> True. Before there were a test min_uV == max_uV && ops->set_voltage and
> now min_uV == max_uV followed by test for ops->set_voltage that returns
> EINVAL if not set (NULL for fixed voltage regulator obviously).
>
> Reviewed-by: Jarkko Nikula <jhnikula@gmail.com>
Thanks adding into devel-fixes.
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints
2011-02-01 15:36 ` Aaro Koskinen
@ 2011-02-04 13:31 ` Sergei Shtylyov
-1 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2011-02-04 13:31 UTC (permalink / raw)
To: Aaro Koskinen; +Cc: tony, linux-omap, linux-arm-kernel
Hello.
On 01-02-2011 18:36, Aaro Koskinen wrote:
> With the commit 757902513019e6ee469791ff76f954b19ca8d036 fixed voltage
Please also specify the commit summary in parens, as asked by Linus.
> regulator setup will fail if there are voltage constraints defined. This
> made MMC unusable on this board. Fix by just deleting those redundant
> constraints.
> Signed-off-by: Aaro Koskinen<aaro.koskinen@nokia.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints
@ 2011-02-04 13:31 ` Sergei Shtylyov
0 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2011-02-04 13:31 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 01-02-2011 18:36, Aaro Koskinen wrote:
> With the commit 757902513019e6ee469791ff76f954b19ca8d036 fixed voltage
Please also specify the commit summary in parens, as asked by Linus.
> regulator setup will fail if there are voltage constraints defined. This
> made MMC unusable on this board. Fix by just deleting those redundant
> constraints.
> Signed-off-by: Aaro Koskinen<aaro.koskinen@nokia.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-02-04 13:32 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-01 15:36 [PATCH] arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints Aaro Koskinen
2011-02-01 15:36 ` Aaro Koskinen
2011-02-01 18:27 ` Jarkko Nikula
2011-02-01 18:27 ` Jarkko Nikula
2011-02-01 23:52 ` Tony Lindgren
2011-02-01 23:52 ` Tony Lindgren
2011-02-04 13:31 ` Sergei Shtylyov
2011-02-04 13:31 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.