From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752450Ab1BCU7e (ORCPT ); Thu, 3 Feb 2011 15:59:34 -0500 Received: from mail-iw0-f174.google.com ([209.85.214.174]:57717 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752247Ab1BCU7c (ORCPT ); Thu, 3 Feb 2011 15:59:32 -0500 Date: Thu, 3 Feb 2011 13:59:28 -0700 From: Grant Likely To: Sebastian Andrzej Siewior Cc: David Gibson , linux-kernel@vger.kernel.org, sodaville@linutronix.de, devicetree-discuss@lists.ozlabs.org, x86@kernel.org Subject: Re: [PATCH TIP 03/14] x86/dtb: Add a device tree for CE4100 Message-ID: <20110203205928.GH6180@angua.secretlab.ca> References: <1295843342-1122-1-git-send-email-bigeasy@linutronix.de> <1295843342-1122-4-git-send-email-bigeasy@linutronix.de> <20110127050027.GB23443@yookeroo> <20110127091147.GA9770@www.tglx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110127091147.GA9770@www.tglx.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2011 at 02:41:47PM +0530, Sebastian Andrzej Siewior wrote: > * David Gibson | 2011-01-27 15:00:27 [+1000]: > >> + >; > >> + > >> + i2c-controller@15a00,0,0 { > > > >Uh.. that unit address does not look right. The encoding of PCI > >3-cell addresses into a unit address string is not simply comma > >separated cells. I forget the details, so you'll need to check the OF > >PCI binding. > > Grant wrote [0]: > |You'll also note that I added ',0,0' to the end of the address. > |That's because the node address reflects the parent bus address format > |which uses 3 cells in this case. It is quite possible I was mistaken on this point. The PCI binding is not my area of strength. g.