From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58079 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PmphK-0006MR-Gy
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 10:41:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PmphI-0006Vt-Ri
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 10:41:46 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43416)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PmphI-0006Va-Ie
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 10:41:44 -0500
Date: Tue, 8 Feb 2011 17:41:12 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110208154112.GA4341@redhat.com>
References: <20110207135001.GA23844@redhat.com>
	<20110208174058.71d73062@skywalker>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110208174058.71d73062@skywalker>
Subject: [Qemu-devel] Re: [PATCH] vhost: disable on tap link down
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: pradeep <psuriset@linux.vnet.ibm.com>
Cc: Juan Quintela <quintela@redhat.com>, Jes.Sorensen@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, Alex Williamson <alex.williamson@redhat.com>, Sridhar Samudrala <samudrala.sridhar@gmail.com>

On Tue, Feb 08, 2011 at 05:40:58PM +0530, pradeep wrote:
> On Mon, 7 Feb 2011 15:50:01 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > qemu makes it possible to disable link at tap
> > which is not communicated to the guest but
> > causes all packets to be dropped.
> > 
> > Handle this with vhost simply by moving to the userspace emulation.
> > 
> > Note: it might be a good idea to make peer link status match
> > tap in this case, so the guest gets an event
> > and updates the carrier state. For now
> > stay bug for bug compatible with what we used to have.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Reported-by: pradeep <psuriset@linux.vnet.ibm.com>
> > ---
> > 
> > Untested.
> > Pradeep, mind trying this patch out and reporting?
> 
> Hi mst
> 
> This patch works. Thanks

Strange actually. Did you put the link down before guest booted?  I went
to test it with set link after guest is up, and it didn't work, I needed
this on top - can you ack this in your setup as well pls?

diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index fc2d6f5..3e3d73a 100644
--- a/hw/virtio-net.c
+++ b/hw/virtio-net.c
@@ -112,14 +112,11 @@ static void virtio_net_vhost_status(VirtIONet *n, uint8_t status)
         return;
     }
 
-    if (n->nic->nc.peer->link_down) {
-        return;
-    }
-
     if (!tap_get_vhost_net(n->nic->nc.peer)) {
         return;
     }
-    if (!!n->vhost_started == virtio_net_started(n, status)) {
+    if (!!n->vhost_started == virtio_net_started(n, status) &&
+        !n->nic->nc.peer->link_down) {
         return;
     }
     if (!n->vhost_started) {