From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Michal Schmidt <mschmidt@redhat.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH] GRO: fix merging a paged skb after non-paged skbs
Date: Wed, 9 Feb 2011 07:54:53 +1100 [thread overview]
Message-ID: <20110208205453.GA590@gondor.apana.org.au> (raw)
In-Reply-To: <1297177484.3325.1.camel@bwh-desktop>
On Tue, Feb 08, 2011 at 03:04:44PM +0000, Ben Hutchings wrote:
>
> That would work, though it looks like Michal has managed to make it
> tolerate switches. (I haven't yet tested the result myself.)
Well the question is do we really want to still keep merging
in case of a switch? It could potentially get messy if it switches
back over and over again.
However, I suppose other merging criteria will stop the merging
in such cases so it's probably not a big deal.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2011-02-08 20:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 17:47 [PATCH] GRO: fix merging a paged skb after non-paged skbs Michal Schmidt
2011-01-24 18:44 ` Eric Dumazet
2011-01-24 22:08 ` [PATCH v2] " Michal Schmidt
2011-01-24 22:22 ` Eric Dumazet
2011-01-24 22:27 ` David Miller
2011-01-25 1:24 ` [PATCH] " Ben Hutchings
2011-02-07 20:39 ` Ben Hutchings
2011-02-08 8:49 ` Herbert Xu
2011-02-08 15:04 ` Ben Hutchings
2011-02-08 20:54 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208205453.GA590@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.