All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] misc: add CARMA DATA-FPGA Access Driver
Date: Wed, 9 Feb 2011 15:35:45 -0800	[thread overview]
Message-ID: <20110209233544.GA5303@ovro.caltech.edu> (raw)
In-Reply-To: <20110209182740.GC23867@core.coreip.homeip.net>

On Wed, Feb 09, 2011 at 10:27:40AM -0800, Dmitry Torokhov wrote:

[ snip stuff I've already fixed in the next version ]

> > 
> > The requirement is that the device stay open during reconfiguration.
> > This provides for that. Readers just block for as long as the device is
> > not producing data.
> 
> OK, you still need to make sure you do not touch free/used buffer while
> device is disabled. Also, you need to kick readers if you unbind the
> driver, so maybe a new flag priv->exists should be introduced and
> checked.
> 

I don't understand what you mean by "kick readers if you unbind the
driver". The kernel automatically increases the refcount on a module
when a process is using the module. This shows up in the "Used by"
column of lsmod's output.

The kernel will not let you rmmod a module with a non-zero refcount. You
cannot get into the situation where you have rmmod'ed the module and a
reader is still blocking in read()/poll().

Thanks for the review. A v6 is coming right up.

Ira

  reply	other threads:[~2011-02-09 23:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08 23:37 [PATCH RFCv5 0/2] CARMA Board Support Ira W. Snyder
2011-02-08 23:37 ` Ira W. Snyder
2011-02-08 23:37 ` [PATCH 1/2] misc: add CARMA DATA-FPGA Access Driver Ira W. Snyder
2011-02-08 23:37   ` Ira W. Snyder
2011-02-09  8:33   ` Dmitry Torokhov
2011-02-09 17:35     ` Ira W. Snyder
2011-02-09 18:27       ` Dmitry Torokhov
2011-02-09 23:35         ` Ira W. Snyder [this message]
2011-02-09 23:42           ` Dmitry Torokhov
2011-02-10  0:10             ` Ira W. Snyder
2011-02-10  0:39               ` Dmitry Torokhov
2011-02-10  9:02                 ` David Laight
2011-02-10  9:02                   ` David Laight
2011-02-08 23:37 ` [PATCH 2/2] misc: add CARMA DATA-FPGA Programmer support Ira W. Snyder
2011-02-08 23:37   ` Ira W. Snyder
  -- strict thread matches above, loose matches on Subject: below --
2011-02-07 23:23 [PATCH RFCv4 0/2] CARMA Board Support Ira W. Snyder
2011-02-07 23:23 ` [PATCH 1/2] misc: add CARMA DATA-FPGA Access Driver Ira W. Snyder
2011-02-08  7:33   ` Dmitry Torokhov
2011-02-08 17:20     ` Ira W. Snyder
2011-02-08 17:29       ` Dave Jones
2011-02-08 17:50       ` Dmitry Torokhov
2011-02-08 19:11         ` Ira W. Snyder
2011-02-08 19:33           ` Dmitry Torokhov
2011-02-09 16:30   ` David Laight
2011-02-09 16:30     ` David Laight
2011-02-09 17:03     ` Ira W. Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110209233544.GA5303@ovro.caltech.edu \
    --to=iws@ovro.caltech.edu \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.