All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Oren Weil <oren.jer.weil@intel.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	david@woodhou.se, david.woodhouse@intel.com
Subject: Re: [RFC PATCH 03/13] Intel(R) MEI Driver
Date: Thu, 10 Feb 2011 10:03:29 -0800	[thread overview]
Message-ID: <20110210180329.GF13795@suse.de> (raw)
In-Reply-To: <b7da2f$qd3ne6@fmsmga001.fm.intel.com>

On Thu, Feb 10, 2011 at 01:55:03AM -0800, Oren Weil wrote:
> diff --git a/drivers/char/mei/Makefile b/drivers/char/mei/Makefile
> new file mode 100644
> index 0000000..a9ac1cb
> --- /dev/null
> +++ b/drivers/char/mei/Makefile
> @@ -0,0 +1,23 @@
> +#
> +# Kbuild - Intel(R) Management Engine Interface (Intel(R) MEI) Linux driver

This is not a Kbuild file, it's a Makefile file.

> +# Copyright (c) 2003-2011, Intel Corporation.

Really?  This file is originally based on 2003?  I find that very hard
to believe.

> +#
> +# This program is free software; you can redistribute it and/or modify it
> +# under the terms and conditions of the GNU General Public License,
> +# version 2, as published by the Free Software Foundation.

Makefiles are not "programs", please remove this from the Makefile, it
is not needed.

> +#
> +# This program is distributed in the hope it will be useful, but WITHOUT
> +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> +# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> +# more details.

This paragraph is not needed.

> +#
> +# You should have received a copy of the GNU General Public License along with
> +# this program; if not, write to the Free Software Foundation, Inc.,
> +# 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.

NEVER put this paragraph in, unless you are going to be willing to
update the file every time the FSF moves office buildings for the rest
of your life.

greg k-h

      parent reply	other threads:[~2011-02-10 18:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-10  9:55 [RFC PATCH 03/13] Intel(R) MEI Driver Oren Weil
2011-02-10 13:48 ` Alan Cox
2011-02-10 18:03 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110210180329.GF13795@suse.de \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=david.woodhouse@intel.com \
    --cc=david@woodhou.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oren.jer.weil@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.