From: "John W. Linville" <linville@tuxdriver.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>,
linux-wireless@vger.kernel.org, lrodriguez@atheros.com
Subject: Re: [PATCH] ath9k: make use of slot time macros
Date: Fri, 11 Feb 2011 11:29:44 -0500 [thread overview]
Message-ID: <20110211162944.GD2224@tuxdriver.com> (raw)
In-Reply-To: <4D5561F2.3050404@openwrt.org>
On Fri, Feb 11, 2011 at 05:21:06PM +0100, Felix Fietkau wrote:
> On 2011-02-11 5:15 PM, John W. Linville wrote:
> > On Fri, Feb 11, 2011 at 01:52:23PM +0100, Felix Fietkau wrote:
> >> On 2011-02-11 8:01 AM, Mohammed Shafi Shajakhan wrote:
> >> > From: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
> >> >
> >> > Instead of using raw numbers to assign slot time it would be better to
> >> > make use of predefined slot time macros
> >> How does this make it better?
> >
> > Maybe if it was ATH9K_SHORT_SLOT_TIME it would make more sense?
> Well, neither the unit of this variable, nor the values that can be used
> are ath9k specific.
True -- the patch is probably an unnecessarily zealous attempt to avoid
"magic numbers" in the code. :-)
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-02-11 16:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 7:01 [PATCH] ath9k: make use of slot time macros Mohammed Shafi Shajakhan
2011-02-11 12:52 ` Felix Fietkau
2011-02-11 16:15 ` John W. Linville
2011-02-11 16:21 ` Felix Fietkau
2011-02-11 16:29 ` John W. Linville [this message]
2011-02-14 4:41 ` Mohammed Shafi
2011-02-14 4:46 ` Mohammed Shafi
2011-02-14 13:48 ` Felix Fietkau
2011-02-14 14:02 ` Mohammed Shafi
2011-02-14 14:29 ` Felix Fietkau
2011-02-14 14:36 ` Mohammed Shafi
2011-02-14 20:14 ` John W. Linville
2011-02-15 6:07 ` Mohammed Shafi
2011-02-14 4:35 ` Mohammed Shafi
2011-02-14 4:31 ` Mohammed Shafi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110211162944.GD2224@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=mshajakhan@atheros.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.