From: Arnd Bergmann <arnd@arndb.de>
To: Chuanxiao Dong <chuanxiao.dong@intel.com>
Cc: linux-mmc@vger.kernel.org, cjb@laptop.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
adrian.hunter@nokia.com
Subject: Re: [PATCH v4 1/3]mmc: set max_discard_sectors value for mmc queue
Date: Sat, 12 Feb 2011 09:38:16 +0100 [thread overview]
Message-ID: <201102120938.16626.arnd@arndb.de> (raw)
In-Reply-To: <20110212062214.GB25519@intel.com>
On Saturday 12 February 2011 07:22:14 Chuanxiao Dong wrote:
> max_discard_sectors value is UINT_MAX which means kernel block layer can pass
> down unlimited sectors to MMC driver to erase. But erasing so many sectors may
> delay some other important I/O requests. This is not preferred.
>
> So use 'pref_erase' to set a suitable max_discard_sectors value for mmc queue to
> avoid erasing too many sectors at one time.
>
> Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
I'm not sure about this one. pref_erase on SDHC cards should be the *minimum*
unit you can erase in one request, not the maximum. Erasing an arbitrary
number of allocation units on an SDHC card should complete almost instantly,
because it only needs to update a single table with the allocation units.
Discarding partial allocation units will take a lot longer, because the
card then has to copy over the remaining blocks.
Arnd
next prev parent reply other threads:[~2011-02-12 8:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 6:22 [PATCH v4 1/3]mmc: set max_discard_sectors value for mmc queue Chuanxiao Dong
2011-02-12 8:38 ` Arnd Bergmann [this message]
2011-02-12 10:42 ` Dong, Chuanxiao
2011-02-12 18:04 ` Arnd Bergmann
2011-02-14 7:01 ` Dong, Chuanxiao
2011-02-14 12:13 ` Arnd Bergmann
2011-02-14 14:08 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102120938.16626.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=adrian.hunter@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=chuanxiao.dong@intel.com \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.