All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: penberg@kernel.org, akpm@linux-foundation.org,
	netdev@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org,
	bugme-daemon@bugzilla.kernel.org, casteyde.christian@free.fr,
	xiaosuo@gmail.com, vegardno@ifi.uio.no,
	linux-kernel@vger.kernel.org
Subject: Re: [Bugme-new] [Bug 27212] New: Warning kmemcheck: Caught 64-bit read from uninitialized memory in netlink_broadcast_filtered
Date: Mon, 14 Feb 2011 11:43:18 -0800 (PST)	[thread overview]
Message-ID: <20110214.114318.112601812.davem@davemloft.net> (raw)
In-Reply-To: <1297704922.2996.60.camel@edumazet-laptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 14 Feb 2011 18:35:22 +0100

> Le vendredi 21 janvier 2011 à 09:49 +0200, Pekka Enberg a écrit :
> 
>> It actually looks like a bug in SLUB+kmemcheck. The 
>> kmemcheck_slab_alloc() call in slab_post_alloc_hook() should use ksize() 
>> instead of s->objsize. SLAB seems to do the right thing already. Anyone 
>> care to send a patch my way?
>> 
> 
> Hmm, what do you think of following patch ?
> 
> Thanks, and sorry for the delay.
> 
> [PATCH] slub: fix kmemcheck calls to match ksize() hints
> 
> Recent use of ksize() in network stack (commit ca44ac38 : net: don't
> reallocate skb->head unless the current one hasn't the needed extra size
> or is shared) triggers kmemcheck warnings, because ksize() can return
> more space than kmemcheck is aware of.
> 
> Pekka Enberg noticed SLAB+kmemcheck is doing the right thing, while SLUB
> +kmemcheck doesnt.
> 
> Bugzilla reference #27212
> 
> Reported-by: Christian Casteyde <casteyde.christian@free.fr>
> Suggested-by: Pekka Enberg <penberg@kernel.org>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Acked-by: David S. Miller <davem@davemloft.net>

  reply	other threads:[~2011-02-14 19:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-27212-10286@https.bugzilla.kernel.org/>
2011-01-20 20:25 ` [Bugme-new] [Bug 27212] New: Warning kmemcheck: Caught 64-bit read from uninitialized memory in netlink_broadcast_filtered Andrew Morton
2011-01-20 20:41   ` Eric Dumazet
2011-01-21  7:49     ` Pekka Enberg
2011-02-14 17:35       ` Eric Dumazet
2011-02-14 19:43         ` David Miller [this message]
2011-02-15  5:48         ` Pekka Enberg
2011-02-15 16:40           ` Christoph Lameter
2011-02-15 22:21           ` David Rientjes
2011-01-26  9:18   ` Eric Dumazet
2011-01-27 22:41     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110214.114318.112601812.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=bugzilla-daemon@bugzilla.kernel.org \
    --cc=casteyde.christian@free.fr \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=penberg@kernel.org \
    --cc=vegardno@ifi.uio.no \
    --cc=xiaosuo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.