From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v6] Userspace grant communication Date: Mon, 14 Feb 2011 14:04:07 -0500 Message-ID: <20110214190407.GC11121@dumpdata.com> References: <1296753544-13323-1-git-send-email-dgdegra@tycho.nsa.gov> <20110214161403.GB11034@dumpdata.com> <4D596C98.4090401@tycho.nsa.gov> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4D596C98.4090401@tycho.nsa.gov> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Daniel De Graaf Cc: jeremy@goop.org, xen-devel@lists.xensource.com, Ian.Campbell@citrix.com List-Id: xen-devel@lists.xenproject.org > > And besides the two questions I posted today they look OK to me. However > > I have on question that I think points to a bug. .. snip .. > I think this will come out with map.index=4, op.index=8192, since the only > entry in priv->maps has map->index = 0 and map->count = 4. Duh! Yes, and that changes how this all works out. .. > much simpler method of an always-incrementing index for generating offsets; > there's no reason that that can't be done here if it looks like there's a > mistake. The code does look correct to me, and I have tested it with variable-size > grants (although not in the 4/1/1 configuration you suggested). That is OK. Thanks for working through this example.