From: Dan Carpenter <error27@gmail.com>
To: Roland Vossen <rvossen@broadcom.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
gregkh@suse.de, linux-wireless@vger.kernel.org, s@fomichev.me
Subject: Re: [PATCH] brcm80211: remove multiple calls to wl_release_fw
Date: Tue, 15 Feb 2011 00:20:05 +0300 [thread overview]
Message-ID: <20110214212005.GL4384@bicker> (raw)
In-Reply-To: <20110214210755.GB26387@sdf-MacBook>
On Tue, Feb 15, 2011 at 12:07:55AM +0300, Stanislav Fomichev wrote:
> > This patch isn't right. It fixes the oops but it introduces some leaks.
> > (We still need to release firmware that was allocated successfully).
> Sorry Dan, but where do you see the leaks? We make a call to
> wl_request_fw and if returns non-zero call wl_release_fw for a cleanup.
>
> I just removed the call to wl_release_fw in the wl_request_fw itself; so
> it should not introduce any leak.
>
> Could you pls clarify?
Ah. Right. I see what you're saying. Your patch looks good to me.
regards,
dan carpenter
next prev parent reply other threads:[~2011-02-14 21:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 15:00 [PATCH] brcm80211: remove multiple calls to wl_release_fw Stanislav Fomichev
2011-02-14 19:59 ` Roland Vossen
2011-02-14 20:22 ` Dan Carpenter
2011-02-14 20:40 ` Roland Vossen
2011-02-14 21:03 ` Stanislav Fomichev
2011-02-14 21:07 ` Stanislav Fomichev
2011-02-14 21:20 ` Dan Carpenter [this message]
2011-02-18 20:57 ` Greg KH
2011-02-19 9:03 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110214212005.GL4384@bicker \
--to=error27@gmail.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
--cc=rvossen@broadcom.com \
--cc=s@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.