From: Heiko Voigt <hvoigt@hvoigt.net>
To: Pat Thoyts <patthoyts@users.sourceforge.net>
Cc: Pat Thoyts <patthoyts@gmail.com>,
Pat Thoyts <patthoyts@googlemail.com>,
git@vger.kernel.org, Jens Lehmann <jens.lehmann@web.de>
Subject: Re: [PATCH] git-gui: Include version check and test for tearoff menu entry
Date: Mon, 14 Feb 2011 22:31:48 +0100 [thread overview]
Message-ID: <20110214213148.GB50815@book.hvoigt.net> (raw)
In-Reply-To: <878vxilndt.fsf_-_@fox.patthoyts.tk>
Hi,
On Mon, Feb 14, 2011 at 01:03:24PM +0000, Pat Thoyts wrote:
> The --all option for git fetch was added in v1.6.6 so ensure we have a usable version before adding
> the menu items.
> Sometimes people use tearoff menus and these offset the entry indices by one.
>
> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
> ---
>
> Heiko Voigt <hvoigt@hvoigt.net> writes:
> >It just came to my mind that I probably should implement a version check
> >of the commandline to ensure that this option is available. Thats why I
> >tagged only this patch with RFC.
> >
> >Cheers Heiko
>
> The posted patch seems fine except that an error is reported if tearoff
> menus are present. So this patch accommodates tearoff's. I looked up
> when the --all option was added (1.6.6) and skip adding the menu entry
> if we have an older version.
>
> Seems to do the right thing.
Works and looks good to me as well. Did not know about tearoff menues
how do you get those?
Cheers Heiko
P.S.: I discovered a whitespace issue in line 258 which came from my patch.
Could you correct that?
next prev parent reply other threads:[~2011-02-14 21:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 16:43 [PATCH 1/2] git-gui: fix deleting item from all_remotes variable Heiko Voigt
2011-02-13 13:20 ` Pat Thoyts
2011-02-13 13:47 ` Heiko Voigt
2011-02-13 13:50 ` [PATCH 1/2] git-gui: refactor remote submenu creation into subroutine Heiko Voigt
2011-02-13 13:57 ` [RFC PATCH 2/2] git-gui: teach fetch/prune menu to do it for all remotes Heiko Voigt
2011-02-14 13:03 ` [PATCH] git-gui: Include version check and test for tearoff menu entry Pat Thoyts
2011-02-14 21:31 ` Heiko Voigt [this message]
2011-02-15 0:31 ` Pat Thoyts
2011-02-17 20:06 ` Heiko Voigt
2011-02-22 18:36 ` [RFC PATCH 2/2] git-gui: teach fetch/prune menu to do it for all remotes Jens Lehmann
2011-02-22 19:28 ` [PATCH 1/2] git-gui: fetch/prune all entry only for more than one entry Heiko Voigt
2011-02-24 0:02 ` Pat Thoyts
2011-02-22 19:30 ` [PATCH 2/2] git-gui: fetch/prune all entry appears last Heiko Voigt
2011-02-23 19:19 ` Jens Lehmann
2011-02-24 0:09 ` Pat Thoyts
2011-02-13 14:05 ` Re: [PATCH 1/2] git-gui: fix deleting item from all_remotes variable Heiko Voigt
2011-02-13 14:15 ` Heiko Voigt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110214213148.GB50815@book.hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=git@vger.kernel.org \
--cc=jens.lehmann@web.de \
--cc=patthoyts@gmail.com \
--cc=patthoyts@googlemail.com \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.