All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: "Taneja, Archit" <archit@ti.com>, "Balbi, Felipe" <balbi@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: OMAP: DSS2: Common IRQ handler for all OMAPs
Date: Tue, 15 Feb 2011 12:57:49 +0200	[thread overview]
Message-ID: <20110215105749.GL2570@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1297759057.2289.40.camel@deskari>

Hi,

On Tue, Feb 15, 2011 at 10:37:37AM +0200, Tomi Valkeinen wrote:
> > This approach looks clean, but isn't IRQF_SHARED used the other way 
> > around. One irq line and multiple handlers?
> 
> That is the case here, isn't it (on omap3)? One interrupt line (the DSS
> irq, the same returned both from dsi.pdev and dispc.pdev), and two
> handlers, one in dispc and one in dsi? Or what do you mean?

IMO, for omap3 it would be better to have irq_chip there. Then you can
keep e.g. DISPC IRQ disabled until dispc.c calls request_irq(). What
happens today if you have IRQ enabled but dispc isn't ready to act on
those ?

> On omap2 there's no dsi code ran, so dispc is the only one requesting
> the irq, and thus IRQF_SHARED is extra. In omap4 there are separate irq
> lines (dsi.pdev and dispc.pdev return different irqs), and so
> IRQF_SHARED is again extra. But I don't see any harm in IRQF_SHARED even
> in omap2/4.

What if another HW requests the wrong IRQ number and it ends up being
your dispc IRQ line ?

-- 
balbi

  parent reply	other threads:[~2011-02-15 10:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-02  8:56 [PATCH] OMAP: DSS2: Common IRQ handler for all OMAPs Archit Taneja
2011-02-14 14:21 ` Tomi Valkeinen
2011-02-14 14:30   ` Felipe Balbi
2011-02-15  4:28     ` archit taneja
2011-02-15  7:27       ` Tomi Valkeinen
2011-02-15  8:30         ` archit taneja
2011-02-15  8:37           ` Tomi Valkeinen
2011-02-15  8:47             ` archit taneja
2011-02-15  9:25             ` archit taneja
2011-02-15 10:23               ` Cousson, Benoit
2011-02-15 10:28                 ` Semwal, Sumit
2011-02-15 10:50                   ` Cousson, Benoit
2011-02-15 12:43                     ` archit taneja
2011-02-15 12:56                       ` Cousson, Benoit
2011-02-15 10:57             ` Felipe Balbi [this message]
2011-02-15 11:25               ` Tomi Valkeinen
2011-02-15 11:42                 ` Felipe Balbi
2011-02-15  8:05       ` Felipe Balbi
2011-02-15  8:20         ` archit taneja
2011-02-15  8:23           ` Felipe Balbi
2011-02-15  7:45     ` Tomi Valkeinen
2011-02-15  8:03       ` archit taneja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110215105749.GL2570@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=archit@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.