From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:20866 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758754Ab1BPJtd (ORCPT ); Wed, 16 Feb 2011 04:49:33 -0500 Date: Wed, 16 Feb 2011 10:49:16 +0100 From: Stanislaw Gruszka To: Johannes Berg Cc: wwguy , Intel Linux Wireless , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH v2] iwlwifi: fix dma mappings and skbs leak Message-ID: <20110216094913.GB2812@redhat.com> References: <1297693947-15310-1-git-send-email-sgruszka@redhat.com> <1297698696.4723.16.camel@wwguy-ubuntu> <20110215113444.GC2162@redhat.com> <1297770602.3935.3.camel@jlt3.sipsolutions.net> <20110215130428.GA2515@redhat.com> <1297775393.3935.15.camel@jlt3.sipsolutions.net> <20110215132202.GC2515@redhat.com> <1297776631.3935.16.camel@jlt3.sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1297776631.3935.16.camel@jlt3.sipsolutions.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Feb 15, 2011 at 02:30:31PM +0100, Johannes Berg wrote: > On Tue, 2011-02-15 at 14:22 +0100, Stanislaw Gruszka wrote: > > On Tue, Feb 15, 2011 at 02:09:53PM +0100, Johannes Berg wrote: > > > Hmm. That's a bit strange, ieee80211_mgd_deauth() should also call > > > ieee80211_set_disassoc()? > > > > But only if ifmgd->associated == req->bss > > Yeah but that means we're deauthenticating from the BSS we're associated > with. How could it be a different one? Maybe you can print them or > something, hmm.. I debug it more, ieee80211_sta_rx_notify() can be called after dissasociate from ieee80211_rx_h_sta_process() when device receive frames and I do rmmod. I'll post proposed fix in separate email. Stanislaw