From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: platform data and mfd design question Date: Wed, 16 Feb 2011 08:53:49 -0800 Message-ID: <20110216165348.GB4390@opensource.wolfsonmicro.com> References: <4D5AF554.2030208@codeaurora.org> <4D5B8F61.3090105@stericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:36086 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753296Ab1BPQxc (ORCPT ); Wed, 16 Feb 2011 11:53:32 -0500 Content-Disposition: inline In-Reply-To: <4D5B8F61.3090105@stericsson.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Linus Walleij Cc: Abhijeet Dharmapurikar , "dilinger@queued.net" , Samuel Ortiz , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Ian Lartey , Dimitris Papastamos , Srinidhi KASAGAR , Michael Hennerich , "linux-arm-msm@vger.kernel.org" On Wed, Feb 16, 2011 at 09:48:33AM +0100, Linus Walleij wrote: > On 02/15/2011 10:51 PM, Abhijeet Dharmapurikar wrote: > >Msm on the other hand declares the struct mfd_cell subdevice[] array in > >the board file and passes this on to the core driver via platfom data. > This way the platform data tells the core driver what kind of > silicon it has "hey, PM8058, guess what, you have an RTC!" > which looks backwards to me, especially given that it does > not need any fancy platform data at all, just two IRQ numbers > which the core driver can very well handle. Indeed, and the RTC would still be useful even without IRQ support I imagine (it should still be able to tell you the time). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753375Ab1BPQxe (ORCPT ); Wed, 16 Feb 2011 11:53:34 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:36086 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753296Ab1BPQxc (ORCPT ); Wed, 16 Feb 2011 11:53:32 -0500 Date: Wed, 16 Feb 2011 08:53:49 -0800 From: Mark Brown To: Linus Walleij Cc: Abhijeet Dharmapurikar , "dilinger@queued.net" , Samuel Ortiz , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Ian Lartey , Dimitris Papastamos , Srinidhi KASAGAR , Michael Hennerich , "linux-arm-msm@vger.kernel.org" Subject: Re: platform data and mfd design question Message-ID: <20110216165348.GB4390@opensource.wolfsonmicro.com> References: <4D5AF554.2030208@codeaurora.org> <4D5B8F61.3090105@stericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D5B8F61.3090105@stericsson.com> X-Cookie: You're at the end of the road again. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 16, 2011 at 09:48:33AM +0100, Linus Walleij wrote: > On 02/15/2011 10:51 PM, Abhijeet Dharmapurikar wrote: > >Msm on the other hand declares the struct mfd_cell subdevice[] array in > >the board file and passes this on to the core driver via platfom data. > This way the platform data tells the core driver what kind of > silicon it has "hey, PM8058, guess what, you have an RTC!" > which looks backwards to me, especially given that it does > not need any fancy platform data at all, just two IRQ numbers > which the core driver can very well handle. Indeed, and the RTC would still be useful even without IRQ support I imagine (it should still be able to tell you the time). From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@opensource.wolfsonmicro.com (Mark Brown) Date: Wed, 16 Feb 2011 08:53:49 -0800 Subject: platform data and mfd design question In-Reply-To: <4D5B8F61.3090105@stericsson.com> References: <4D5AF554.2030208@codeaurora.org> <4D5B8F61.3090105@stericsson.com> Message-ID: <20110216165348.GB4390@opensource.wolfsonmicro.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Feb 16, 2011 at 09:48:33AM +0100, Linus Walleij wrote: > On 02/15/2011 10:51 PM, Abhijeet Dharmapurikar wrote: > >Msm on the other hand declares the struct mfd_cell subdevice[] array in > >the board file and passes this on to the core driver via platfom data. > This way the platform data tells the core driver what kind of > silicon it has "hey, PM8058, guess what, you have an RTC!" > which looks backwards to me, especially given that it does > not need any fancy platform data at all, just two IRQ numbers > which the core driver can very well handle. Indeed, and the RTC would still be useful even without IRQ support I imagine (it should still be able to tell you the time).