From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756251Ab1BQNN7 (ORCPT ); Thu, 17 Feb 2011 08:13:59 -0500 Received: from www.tglx.de ([62.245.132.106]:59035 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751759Ab1BQNN5 (ORCPT ); Thu, 17 Feb 2011 08:13:57 -0500 Date: Thu, 17 Feb 2011 14:13:40 +0100 From: Sebastian Andrzej Siewior To: Grant Likely Cc: Sebastian Andrzej Siewior , sodaville@linutronix.de, devicetree-discuss@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, Andres Salomon Subject: Re: [sodaville] [PATCH OF 12/14] x86/rtc: don't register rtc if we the DT blob Message-ID: <20110217131340.GA13500@www.tglx.de> References: <1295843342-1122-1-git-send-email-bigeasy@linutronix.de> <1295843342-1122-13-git-send-email-bigeasy@linutronix.de> <20110216220921.GI22837@angua.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20110216220921.GI22837@angua.secretlab.ca> User-Agent: Mutt/1.4.2.2i X-Key-Id: 97C4700B X-Key-Fingerprint: 09E2 D1F3 9A3A FF13 C3D3 961C 0688 1C1E 97C4 700B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Grant Likely | 2011-02-16 15:09:21 [-0700]: >> @@ -236,6 +237,8 @@ static __init int add_rtc_cmos(void) >> } >> } >> #endif >> + if (of_have_populated_dt()) >> + return 0; > >Hmmm, should this hunk be moved to the next patch to preserve bisectability? Makes sense. Without this chunk it is simply adding of_have_populated_dt(). So I merge with the next patch. >g. Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [sodaville] [PATCH OF 12/14] x86/rtc: don't register rtc if we the DT blob Date: Thu, 17 Feb 2011 14:13:40 +0100 Message-ID: <20110217131340.GA13500@www.tglx.de> References: <1295843342-1122-1-git-send-email-bigeasy@linutronix.de> <1295843342-1122-13-git-send-email-bigeasy@linutronix.de> <20110216220921.GI22837@angua.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20110216220921.GI22837-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: Sebastian Andrzej Siewior , x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sodaville-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, Andres Salomon , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org * Grant Likely | 2011-02-16 15:09:21 [-0700]: >> @@ -236,6 +237,8 @@ static __init int add_rtc_cmos(void) >> } >> } >> #endif >> + if (of_have_populated_dt()) >> + return 0; > >Hmmm, should this hunk be moved to the next patch to preserve bisectability? Makes sense. Without this chunk it is simply adding of_have_populated_dt(). So I merge with the next patch. >g. Sebastian