From: Eric B Munson <emunson@mgebm.net>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michael J Wolf <mjwolf@us.ibm.com>,
Andrea Arcangeli <aarcange@redhat.com>,
akpm@osdl.org, Mel Gorman <mel@csn.ul.ie>
Subject: Re: [PATCH 1/5] pagewalk: only split huge pages when necessary
Date: Wed, 23 Feb 2011 10:30:30 -0500 [thread overview]
Message-ID: <20110223153030.GA2810@mgebm.net> (raw)
In-Reply-To: <20110222015339.0C9A2212@kernel>
[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]
On Mon, 21 Feb 2011, Dave Hansen wrote:
>
> v2 - rework if() block, and remove now redundant split_huge_page()
>
> Right now, if a mm_walk has either ->pte_entry or ->pmd_entry
> set, it will unconditionally split any transparent huge pages
> it runs in to. In practice, that means that anyone doing a
>
> cat /proc/$pid/smaps
>
> will unconditionally break down every huge page in the process
> and depend on khugepaged to re-collapse it later. This is
> fairly suboptimal.
>
> This patch changes that behavior. It teaches each ->pmd_entry
> handler (there are five) that they must break down the THPs
> themselves. Also, the _generic_ code will never break down
> a THP unless a ->pte_entry handler is actually set.
>
> This means that the ->pmd_entry handlers can now choose to
> deal with THPs without breaking them down.
>
> Acked-by: Mel Gorman <mel@csn.ul.ie>
> Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
I have been running this set for serveral hours now and viewing
various smaps files is not causing wild shifts in my AnonHugePages:
counter.
Reviewed-and-tested-by: Eric B Munson <emunson@mgebm.net>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-02-23 15:30 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 1:53 [PATCH 0/5] fix up /proc/$pid/smaps to not split huge pages Dave Hansen
2011-02-22 1:53 ` Dave Hansen
2011-02-22 1:53 ` [PATCH 1/5] pagewalk: only split huge pages when necessary Dave Hansen
2011-02-22 1:53 ` Dave Hansen
2011-02-22 21:21 ` David Rientjes
2011-02-22 21:21 ` David Rientjes
2011-02-23 15:30 ` Eric B Munson [this message]
2011-02-22 1:53 ` [PATCH 2/5] break out smaps_pte_entry() from smaps_pte_range() Dave Hansen
2011-02-22 1:53 ` Dave Hansen
2011-02-22 21:21 ` David Rientjes
2011-02-22 21:21 ` David Rientjes
2011-02-23 15:30 ` Eric B Munson
2011-02-22 1:53 ` [PATCH 3/5] pass pte size argument in to smaps_pte_entry() Dave Hansen
2011-02-22 1:53 ` Dave Hansen
2011-02-22 21:21 ` David Rientjes
2011-02-22 21:21 ` David Rientjes
2011-02-23 15:30 ` Eric B Munson
2011-02-22 1:53 ` [PATCH 4/5] teach smaps_pte_range() about THP pmds Dave Hansen
2011-02-22 1:53 ` Dave Hansen
2011-02-22 13:35 ` Andrea Arcangeli
2011-02-22 13:35 ` Andrea Arcangeli
2011-02-22 21:22 ` David Rientjes
2011-02-22 21:22 ` David Rientjes
2011-02-23 15:31 ` Eric B Munson
2011-02-22 1:53 ` [PATCH 5/5] have smaps show transparent huge pages Dave Hansen
2011-02-22 1:53 ` Dave Hansen
2011-02-23 15:31 ` Eric B Munson
-- strict thread matches above, loose matches on Subject: below --
2011-02-09 19:54 [PATCH 0/5] fix up /proc/$pid/smaps to not split " Dave Hansen
2011-02-09 19:54 ` [PATCH 1/5] pagewalk: only split huge pages when necessary Dave Hansen
2011-02-09 19:54 ` Dave Hansen
2011-02-10 11:11 ` Mel Gorman
2011-02-10 11:11 ` Mel Gorman
2011-02-10 13:19 ` Andrea Arcangeli
2011-02-10 13:19 ` Andrea Arcangeli
2011-02-10 13:34 ` Mel Gorman
2011-02-10 13:34 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110223153030.GA2810@mgebm.net \
--to=emunson@mgebm.net \
--cc=aarcange@redhat.com \
--cc=akpm@osdl.org \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mjwolf@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.