From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp-vbr13.xs4all.nl ([194.109.24.33]:4114 "EHLO smtp-vbr13.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867Ab1BXNvy (ORCPT ); Thu, 24 Feb 2011 08:51:54 -0500 From: Hans Verkuil To: Mauro Carvalho Chehab Subject: Re: oops cx2341x control handler Date: Thu, 24 Feb 2011 14:51:30 +0100 Cc: Matt Janus , linux-media@vger.kernel.org, Andy Walls References: <9AA38BEC-4364-4F45-968B-E33BA5098C34@mattjan.us> <201101252229.35418.hverkuil@xs4all.nl> <4D666116.70605@redhat.com> In-Reply-To: <4D666116.70605@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201102241451.30452.hverkuil@xs4all.nl> List-ID: Sender: On Thursday, February 24, 2011 14:45:58 Mauro Carvalho Chehab wrote: > Em 25-01-2011 19:29, Hans Verkuil escreveu: > > Hi Matt, > > > > On Tuesday, January 25, 2011 03:10:38 Matt Janus wrote: > >> A quick test with mplayer didn't error, when i tried to use mythtv the driver crashed and resulted in this: > > > > I could reproduce this and the fix is below. Please test! > > What's the status of this patch? Should it be applied or not? Absolutely! It's a nasty bug. Regards, Hans > > Cheers, > Mauro > > > > Regards, > > > > Hans > > > > From 6b7c84508e915f26a9b701ef2f5fa0b92ca62f2f Mon Sep 17 00:00:00 2001 > > Message-Id: <6b7c84508e915f26a9b701ef2f5fa0b92ca62f2f.1295990866.git.hverkuil@xs4all.nl> > > From: Hans Verkuil > > Date: Tue, 25 Jan 2011 22:25:39 +0100 > > Subject: [PATCH] cx18: fix kernel oops when setting MPEG control before capturing. > > > > The cxhdl->priv field was not set initially, only after capturing started. > > > > Signed-off-by: Hans Verkuil > > --- > > drivers/media/video/cx18/cx18-driver.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/media/video/cx18/cx18-driver.c b/drivers/media/video/cx18/cx18-driver.c > > index 869690b..877e201 100644 > > --- a/drivers/media/video/cx18/cx18-driver.c > > +++ b/drivers/media/video/cx18/cx18-driver.c > > @@ -713,6 +713,7 @@ static int __devinit cx18_init_struct1(struct cx18 *cx) > > cx->cxhdl.capabilities = CX2341X_CAP_HAS_TS | CX2341X_CAP_HAS_SLICED_VBI; > > cx->cxhdl.ops = &cx18_cxhdl_ops; > > cx->cxhdl.func = cx18_api_func; > > + cx->cxhdl.priv = &cx->streams[CX18_ENC_STREAM_TYPE_MPG]; > > ret = cx2341x_handler_init(&cx->cxhdl, 50); > > if (ret) > > return ret; > > -- Hans Verkuil - video4linux developer - sponsored by Cisco