All of
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <>
To: Benjamin Tissoires <>
Cc: "Jiri Kosina" <>,
	"Dmitry Torokhov" <>,
	"Stéphane Chatty" <>,,
Subject: Re: [PATCH] hid: Do not create input devices for feature reports
Date: Fri, 25 Feb 2011 18:19:11 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Benjamin,

> after some quick tests, I can deal with our two options (changing
> feature_mapping signature or not, and so calling feature_mapping
> before or after input_mapping).

Good, good.

> So, my questions are:
> - do we really need to change feature_mapping signature?
> - is feature_mapping tied to an input or to a device?

The input, output and feature reports are all found on the same level
in the HID protocol, so it makes sense to associate all reports with
the device itself, without any assumed association between different
reports. From a practical point of view, we may assign different input
nodes (input devices) to different input reports, so it is clear that
the mapping between hid device and input device is not 1-to-1.

For output devices, the only supported case is EV_LED, which passes
events to the input device. It is probably assumed that
HID_QUIRK_MULTI_INPUT is false for those devices. Jiri?

For feature reports, the lack of 1-1 correspondence suggests the input
device is ill-defined, and should therefore be left out of the
argument list of the callback. However, I will leave that to Jiri or
anyone more experienced with the HID layer.


  reply	other threads:[~2011-02-25 17:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-24 18:30 [PATCH] hid: Do not create input devices for feature reports Henrik Rydberg
2011-02-24 19:50 ` Benjamin Tissoires
2011-02-24 19:50   ` Benjamin Tissoires
2011-02-24 20:43   ` Henrik Rydberg
2011-02-25 11:18     ` Benjamin Tissoires
2011-02-25 11:18       ` Benjamin Tissoires
2011-02-25 17:19       ` Henrik Rydberg [this message]
2011-03-01 17:54         ` Dmitry Torokhov
2011-03-02 15:02           ` Henrik Rydberg
2011-03-03  8:07             ` Dmitry Torokhov
2011-03-01 16:03 ` Jiri Kosina
2011-03-01 16:21   ` Benjamin Tissoires
2011-03-01 16:21     ` Benjamin Tissoires
2011-03-01 16:26     ` Jiri Kosina
2011-03-08  3:44       ` Rafi Rubin
2011-03-10 16:16       ` Henrik Rydberg
2011-03-10 18:00         ` Jiri Kosina
2011-03-10 18:04           ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.