From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757286Ab1CBTpC (ORCPT ); Wed, 2 Mar 2011 14:45:02 -0500 Received: from mail-bw0-f46.google.com ([209.85.214.46]:43437 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754360Ab1CBTpA (ORCPT ); Wed, 2 Mar 2011 14:45:00 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=s2x0ZXsC/2WP9qRUPCAA8zxjELjDmnptAPVnIyFT/AfnE5JN7tm5VpIsK3paSzykKv Ua3ZwjH7XTCBVRc4vyOmwUxU47aq7sltBkSz1zHXztFHLZQzT8Bhgd1vGt7Dd7vlI8R0 cbiWabT3x/j2HOVI2JdqX0ZGvpK+cz0348XTE= Date: Wed, 2 Mar 2011 22:43:54 +0300 From: Vasiliy Kulikov To: Jake Edge Cc: linux-kernel@vger.kernel.org, mjt@tls.msk.ru, arnd@arndb.de, mirqus@gmail.com, netdev@vger.kernel.org, Ben Hutchings , David Miller , kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, eric.dumazet@gmail.com, therbert@google.com, xiaosuo@gmail.com, jesse@nicira.com, kees.cook@canonical.com, eugene@redhat.com, dan.j.rosenberg@gmail.com, akpm@linux-foundation.org Subject: Re: [PATCH v2] net: don't allow CAP_NET_ADMIN to load non-netdev kernel modules Message-ID: <20110302194354.GA31043@albatros> References: <201102272122.52643.arnd@arndb.de> <4D6B6AE7.2050202@msgid.tls.msk.ru> <20110228095133.GA4351@albatros> <20110228.112349.104067277.davem@davemloft.net> <20110301194845.GA3533@albatros> <1299010390.2529.30.camel@bwh-desktop> <20110301213313.GA6507@albatros> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 02, 2011 at 12:39 -0700, Jake Edge wrote: > > @@ -1765,4 +1765,4 @@ module_exit(ipgre_fini); > > MODULE_LICENSE("GPL"); > > MODULE_ALIAS_RTNL_LINK("gre"); > > MODULE_ALIAS_RTNL_LINK("gretap"); > > -MODULE_ALIAS("gre0"); > > +MODULE_ALIAS_NETDEV("gre0"); > > that is, instead of replacing MODULE_ALIAS("gre0") with the NETDEV > version, don't you want both for backward compatibility? The networking script will run with CAP_NET_ADMIN, this would request netdev-gre0 and load ip_gre. -- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments